Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-magistrate): ensure unique bridgechain name per business #3132

Merged
merged 7 commits into from Oct 26, 2019

Conversation

@dated
Copy link
Contributor

dated commented Oct 25, 2019

Summary

Closes #3126.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@dated dated force-pushed the dated:feat/uniqueness-bridgechains branch to 7e5ca38 Oct 25, 2019
dated added 4 commits Oct 25, 2019
@dated dated marked this pull request as ready for review Oct 25, 2019
Co-Authored-By: supaiku <1311798+supaiku0@users.noreply.github.com>
@supaiku0 supaiku0 self-requested a review Oct 25, 2019
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Oct 25, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@supaiku0 supaiku0 merged commit f2ced87 into ArkEcosystem:develop Oct 26, 2019
81 checks passed
81 checks passed
crypto (12.x)
Details
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
integration (12.x)
Details
bridgechain-update (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
e2e (12.x)
Details
business-registration (12.x)
Details
business-registration (12.x)
Details
business-resignation (12.x)
Details
business-resignation (12.x)
Details
business-update (12.x)
Details
business-update (12.x)
Details
delegate-registration (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (12.x)
Details
htlc-refund (12.x)
Details
ipfs (12.x)
Details
ipfs (12.x)
Details
multi-payment (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (12.x)
Details
transfer (12.x)
Details
vote (12.x)
Details
vote (12.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codeclimate All good!
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Oct 26, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Oct 26, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the dated:feat/uniqueness-bridgechains branch Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.