Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api) include typeGroup in `/transactions/fees` and `/node/fees` endpoints #3193

Merged
merged 4 commits into from Nov 2, 2019

Conversation

@supaiku0
Copy link
Contributor

supaiku0 commented Nov 2, 2019

Summary

Resolves #3182

/transactions/fees

{
  "data": {
    "1": {
      "transfer": "10000000",
      "secondSignature": "500000000",
      "delegateRegistration": "2500000000",
      "vote": "100000000",
      "multiSignature": "500000000",
      "ipfs": "500000000",
      "multiPayment": "10000000",
      "delegateResignation": "2500000000",
      "htlcLock": "10000000",
      "htlcClaim": "0",
      "htlcRefund": "0"
    },
    "2": {
      "businessRegistration": "5000000000",
      "businessResignation": "5000000000",
      "businessUpdate": "5000000000",
      "bridgechainRegistration": "5000000000",
      "bridgechainResignation": "5000000000",
      "bridgechainUpdate": "5000000000"
    }
  }
}

/node/fees

{
  "meta": {
    "days": 7
  },
  "data": {
    "1": {
      "transfer": {
        "avg": "9949783",
        "max": "10000000",
        "min": "1000000",
        "sum": "9949782967"
      },
      "secondSignature": {
        "avg": "500000000",
        "max": "500000000",
        "min": "500000000",
        "sum": "500000000"
      },
      "delegateRegistration": {
        "avg": "2500000000",
        "max": "2500000000",
        "min": "2500000000",
        "sum": "7500000000"
      },
      "vote": {
        "avg": "79130980",
        "max": "100000000",
        "min": "8000000",
        "sum": "1345226667"
      },
      "multiSignature": {
        "avg": "2000000000",
        "max": "2000000000",
        "min": "2000000000",
        "sum": "2000000000"
      },
      "ipfs": {
        "avg": "500000000",
        "max": "500000000",
        "min": "500000000",
        "sum": "1500000000"
      },
      "multiPayment": {
        "avg": "184585153",
        "max": "20000000000",
        "min": "10000000",
        "sum": "42270000000"
      },
      "delegateResignation": {
        "avg": "2500000000",
        "max": "2500000000",
        "min": "2500000000",
        "sum": "15000000000"
      },
      "htlcLock": {
        "avg": "2009000000",
        "max": "20000000000",
        "min": "10000000",
        "sum": "20090000000"
      }
    },
    "2": {
      "businessRegistration": {
        "avg": "4853992568",
        "max": "5000000000",
        "min": "100000000",
        "sum": "635873026450"
      },
      "bridgechainRegistration": {
        "avg": "4969375000",
        "max": "5000000000",
        "min": "100000000",
        "sum": "795100000000"
      }
    }
  }
}

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #3193 into develop will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
+ Coverage    65.67%   65.68%   +0.01%     
===========================================
  Files          426      426              
  Lines        11965    11981      +16     
  Branches      1603     1605       +2     
===========================================
+ Hits          7858     7870      +12     
- Misses        4074     4078       +4     
  Partials        33       33
Impacted Files Coverage Δ
...s/core-api/src/handlers/transactions/controller.ts 73.61% <100%> (+3.76%) ⬆️
packages/core-api/src/handlers/node/controller.ts 62.22% <50%> (-3.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69c129...ba51a83. Read the comment docs.

@faustbrian faustbrian merged commit a9840e5 into develop Nov 2, 2019
62 checks passed
62 checks passed
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (12.x)
Details
business-resignation (12.x)
Details
business-update (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (12.x)
Details
ipfs (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (12.x)
Details
vote (12.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codeclimate All good!
Details
codecov/patch 77.77% of diff hit (target 65.67%)
Details
codecov/project 65.68% (+0.01%) compared to f69c129
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No new, high severity issues
Details
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the fix/core-api/fees-endpoints branch Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.