Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): implement Address.fromWIF method #3228

Merged
merged 5 commits into from Nov 8, 2019

Conversation

@faustbrian
Copy link
Collaborator

faustbrian commented Nov 7, 2019

Summary

Shortcut for Identities.Address.fromPublicKey(Identities.PublicKey.fromWIF(...)).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
faustbrian added 2 commits Nov 7, 2019
wip
wip
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #3228 into develop will decrease coverage by 35.91%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3228       +/-   ##
============================================
- Coverage     65.5%   29.59%   -35.92%     
============================================
  Files          429      429               
  Lines        12090    12091        +1     
  Branches      1628     1628               
============================================
- Hits          7920     3578     -4342     
- Misses        4137     8487     +4350     
+ Partials        33       26        -7
Impacted Files Coverage Δ
packages/crypto/src/identities/address.ts 64.51% <33.33%> (-35.49%) ⬇️
packages/core-utils/src/has-some-property.ts 0% <0%> (-100%) ⬇️
...ckages/core-jest-matchers/src/fields/public-key.ts 0% <0%> (-100%) ⬇️
.../core-jest-matchers/src/transactions/types/ipfs.ts 0% <0%> (-100%) ⬇️
...ackages/core-blockchain/src/machines/blockchain.ts 0% <0%> (-100%) ⬇️
...ypto/src/transactions/utils/bridgechain-schemas.ts 0% <0%> (-100%) ⬇️
packages/core-utils/src/capped-set.ts 0% <0%> (-100%) ⬇️
.../core-jest-matchers/src/transactions/types/vote.ts 0% <0%> (-100%) ⬇️
packages/core-utils/src/nsect.ts 0% <0%> (-100%) ⬇️
...n/src/processor/handlers/already-forged-handler.ts 0% <0%> (-100%) ⬇️
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dbc8a8...286c0e5. Read the comment docs.

@faustbrian faustbrian merged commit c1eafab into develop Nov 8, 2019
60 of 62 checks passed
60 of 62 checks passed
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (12.x)
Details
business-resignation (12.x)
Details
business-update (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (12.x)
Details
ipfs (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (12.x)
Details
vote (12.x)
Details
codecov/patch 33.33% of diff hit (target 65.5%)
Details
codecov/project 29.59% (-35.92%) compared to 5dbc8a8
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codeclimate All good!
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the feat/addr-wif branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.