Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): move verifySignatures into Transactions.Verifier #3231

Merged
merged 4 commits into from Nov 8, 2019

Conversation

@faustbrian
Copy link
Collaborator

faustbrian commented Nov 8, 2019

Summary

Move the verifySignatures from core-state to the crypto package as it makes more sense to be there together with the other verification methods.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Nov 8, 2019

This pull request introduces 1 alert when merging 59e0853 into 7acf6cc - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #3231 into develop will decrease coverage by 16.55%.
The diff coverage is 10.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3231       +/-   ##
============================================
- Coverage    65.51%   48.95%   -16.56%     
============================================
  Files          429      429               
  Lines        12091    12093        +2     
  Branches      1628     1628               
============================================
- Hits          7921     5920     -2001     
- Misses        4137     6150     +2013     
+ Partials        33       23       -10
Impacted Files Coverage Δ
packages/crypto/src/transactions/verifier.ts 51.85% <4%> (-41.26%) ⬇️
packages/core-state/src/wallets/wallet.ts 89.36% <66.66%> (+1.32%) ⬆️
...ages/core-api/src/handlers/transactions/methods.ts 0% <0%> (-100%) ⬇️
...s/core-api/src/handlers/shared/schemas/block-id.ts 0% <0%> (-100%) ⬇️
packages/core-tester-cli/src/logger.ts 0% <0%> (-100%) ⬇️
.../core-api/src/handlers/transactions/transformer.ts 0% <0%> (-100%) ⬇️
packages/core-api/src/handlers/peers/schema.ts 0% <0%> (-100%) ⬇️
...ackages/core-api/src/handlers/locks/transformer.ts 0% <0%> (-100%) ⬇️
...kages/core-api/src/handlers/transactions/routes.ts 0% <0%> (-100%) ⬇️
...kages/core-tester-cli/src/commands/debug/verify.ts 0% <0%> (-100%) ⬇️
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7acf6cc...4fcd3f8. Read the comment docs.

@faustbrian faustbrian merged commit 2a8fa00 into develop Nov 8, 2019
60 of 62 checks passed
60 of 62 checks passed
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (12.x)
Details
business-resignation (12.x)
Details
business-update (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (12.x)
Details
ipfs (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (12.x)
Details
vote (12.x)
Details
codecov/patch 10.71% of diff hit (target 65.51%)
Details
codecov/project 48.95% (-16.56%) compared to 7acf6cc
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codeclimate Approved by Brian Faust.
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@faustbrian faustbrian deleted the verifySignatures branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.