Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-api): do not include /api prefix in pagination #3381

Merged
merged 6 commits into from Jan 10, 2020

Conversation

@air1one
Copy link
Collaborator

air1one commented Jan 9, 2020

Summary

Resolves #3378

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #3381 into develop will increase coverage by 0.3%.
The diff coverage is 86.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #3381     +/-   ##
==========================================
+ Coverage    66.02%   66.32%   +0.3%     
==========================================
  Files          438      438             
  Lines        12294    12334     +40     
  Branches      1664     1674     +10     
==========================================
+ Hits          8117     8181     +64     
+ Misses        4145     4121     -24     
  Partials        32       32
Impacted Files Coverage Δ
...ackages/core-magistrate-transactions/src/errors.ts 94.73% <ø> (+9.02%) ⬆️
...te-crypto/src/builders/bridgechain-registration.ts 0% <0%> (ø) ⬆️
...rate-crypto/src/transactions/bridgechain-update.ts 100% <100%> (ø) ⬆️
...rypto/src/transactions/bridgechain-registration.ts 100% <100%> (ø) ⬆️
...te-transactions/src/handlers/bridgechain-update.ts 43.24% <50%> (+26.34%) ⬆️
...ansactions/src/handlers/bridgechain-resignation.ts 61.53% <66.66%> (+13.53%) ⬆️
packages/core-transaction-pool/src/storage.ts 97.5% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83f168...f2562da. Read the comment docs.

air1one added 4 commits Jan 9, 2020
…refix
…ub.com:ArkEcosystem/core into refactor/core-api/pagination-remove-api-prefix
@air1one air1one marked this pull request as ready for review Jan 9, 2020
@faustbrian faustbrian changed the title refactor: do not include /api prefix in pagination refactor(core-api): do not include /api prefix in pagination Jan 10, 2020
@faustbrian faustbrian merged commit 49d3660 into develop Jan 10, 2020
62 checks passed
62 checks passed
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (12.x)
Details
business-resignation (12.x)
Details
business-update (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (12.x)
Details
ipfs (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (12.x)
Details
vote (12.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codeclimate All good!
Details
codecov/patch 86.27% of diff hit (target 66.02%)
Details
codecov/project 66.32% (+0.3%) compared to a83f168
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@faustbrian faustbrian deleted the refactor/core-api/pagination-remove-api-prefix branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.