Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exchange-json-rpc): use @arkecosystem/exchange-json-rpc@2.0.0 #3458

Merged
merged 3 commits into from Feb 11, 2020
Merged

Conversation

@faustbrian
Copy link
Collaborator

faustbrian commented Feb 10, 2020

This PR will fail until tomorrow when the RPC is tagged.

wip
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #3458 into develop will increase coverage by 16.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3458       +/-   ##
============================================
+ Coverage    49.39%   66.16%   +16.76%     
============================================
  Files          439      439               
  Lines        12458    12458               
  Branches      1708     1708               
============================================
+ Hits          6154     8243     +2089     
+ Misses        6283     4181     -2102     
- Partials        21       34       +13     
Impacted Files Coverage Δ
packages/core-p2p/src/network-monitor.ts 73.46% <0.00%> (+0.76%) ⬆️
packages/core-state/src/wallets/wallet-manager.ts 90.72% <0.00%> (+1.61%) ⬆️
packages/core-transaction-pool/src/memory.ts 98.66% <0.00%> (+2.00%) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 93.18% <0.00%> (+4.54%) ⬆️
packages/core-transaction-pool/src/connection.ts 91.86% <0.00%> (+6.09%) ⬆️
packages/core-p2p/src/peer-connector.ts 67.44% <0.00%> (+6.97%) ⬆️
packages/core-p2p/src/utils/is-valid-version.ts 100.00% <0.00%> (+7.14%) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 65.00% <0.00%> (+8.33%) ⬆️
...ain/src/processor/handlers/accept-block-handler.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/core-p2p/src/peer-processor.ts 81.25% <0.00%> (+10.41%) ⬆️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabd270...e4ca3ac. Read the comment docs.

@faustbrian faustbrian merged commit 13d7f83 into develop Feb 11, 2020
61 checks passed
61 checks passed
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x)
Details
business-registration (12.x)
Details
business-resignation (12.x)
Details
business-update (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (12.x)
Details
ipfs (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (12.x)
Details
vote (12.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codecov/patch Coverage not affected when comparing dabd270...e4ca3ac
Details
codecov/project 66.16% (+16.76%) compared to dabd270
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) No manifest changes detected
security/snyk - package.json (ArkEcosystem) No new, high severity issues
Details
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-container/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) No new, high severity issues
Details
security/snyk - packages/core-explorer/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-utils/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the rpc branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.