Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-kernel): add symbol for TransactionHandlerProvider #3496

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@sebastijankuzner
Copy link

sebastijankuzner commented Feb 13, 2020

Added symbol for TransactionHandlerProvider to provide support for test core-transactions package.

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
…sactionHandlerProvider
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (3.0@704644f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.0    #3496   +/-   ##
======================================
  Coverage       ?   46.93%           
======================================
  Files          ?      536           
  Lines          ?    13669           
  Branches       ?     1856           
======================================
  Hits           ?     6416           
  Misses         ?     7224           
  Partials       ?       29
Impacted Files Coverage Δ
packages/core-transactions/src/service-provider.ts 0% <ø> (ø)
...core-transactions/src/handlers/handler-registry.ts 0% <ø> (ø)
packages/core-kernel/src/ioc/identifiers.ts 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704644f...38bf5bc. Read the comment docs.

@faustbrian faustbrian changed the title refactor(core-transactions, core-kernel): add and use symbol for Tran… refactor(core-kernel): add symbol for TransactionHandlerProvider Feb 13, 2020
@faustbrian faustbrian merged commit 5834847 into 3.0 Feb 13, 2020
37 of 61 checks passed
37 of 61 checks passed
lint (12.x)
Details
test-unit (12.x)
Details
test-integration (12.x)
Details
test-functional-bridgechain-registration (12.x)
Details
test-functional-bridgechain-resignation (12.x)
Details
test-functional-bridgechain-update (12.x)
Details
test-functional-business-registration (12.x)
Details
test-functional-business-resignation (12.x)
Details
test-functional-business-update (12.x)
Details
test-functional-delegate-registration (12.x)
Details
test-functional-delegate-resignation (12.x)
Details
test-functional-htlc-claim (12.x)
Details
test-functional-htlc-lock (12.x)
Details
test-functional-htlc-refund (12.x)
Details
test-functional-ipfs (12.x)
Details
test-functional-multi-payment (12.x)
Details
test-functional-multi-signature-registration (12.x)
Details
test-functional-second-signature-registration (12.x)
Details
test-functional-transfer (12.x)
Details
test-functional-vote (12.x)
Details
benchmark (12.x)
Details
security/snyk - __tests__/e2e/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-container/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-database-postgres/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-elasticsearch/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-error-tracker-airbrake/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-error-tracker-bugsnag/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-error-tracker-raygun/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-error-tracker-rollbar/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-error-tracker-sentry/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-event-emitter/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-exchange-json-rpc/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-explorer/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-http-utils/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-interfaces/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-jest-matchers/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-logger-signale/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-logger-winston/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-logger/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-new-relic/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-snapshots/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-tester-cli/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-utils/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-vote-report/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - packages/core-wallet-api/package.json (ArkEcosystem) Manifest not found
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
security/snyk - package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-api/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-blockchain/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-database/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-forger/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-logger-pino/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-p2p/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-state/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transaction-pool/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-transactions/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core-webhooks/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/core/package.json (ArkEcosystem) No manifest changes detected
security/snyk - packages/crypto/package.json (ArkEcosystem) No manifest changes detected
@ArkEcosystemBot ArkEcosystemBot deleted the refactor-missing-symbols branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.