Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-state): wallet repositories #3501

Merged
merged 2 commits into from Feb 14, 2020

Conversation

@rainydio
Copy link
Contributor

rainydio commented Feb 14, 2020

Summary

Related to #3499

  • Temp wallet repository is renamed into wallet repository clone
  • Added copy-on-write wallet repository/ Actually it isn't copy-on-write, but copy-on-read and with many asterisks.

Although pool would really benefit from proper copy-on-write implementation. This particular, quite limited one is enough for current use. Eventually it will be replaced.

Checklist

  • Ready to be merged
* Temp wallet repository is renamed into wallet repository clone
* Added copy-on-write wallet repository/ Actually it isn't copy-on-write, but copy-on-read and with many asterisks.

Although pool would really benefit from proper copy-on-write implementation. This particular, quite limited one is enough for current use. Eventually it will be replaced.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #3501 into 3.0 will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #3501      +/-   ##
==========================================
+ Coverage   47.15%   47.19%   +0.03%     
==========================================
  Files         535      536       +1     
  Lines       13605    13594      -11     
  Branches     1848     1846       -2     
==========================================
  Hits         6416     6416              
+ Misses       7160     7149      -11     
  Partials       29       29              
Impacted Files Coverage Δ
packages/core-transaction-pool/src/memory.ts 0.00% <0.00%> (ø) ⬆️
packages/core-transaction-pool/src/cleaner.ts 0.00% <0.00%> (ø) ⬆️
packages/core-transaction-pool/src/connection.ts 0.00% <0.00%> (ø) ⬆️
...ages/core-transaction-pool/src/service-provider.ts 0.00% <0.00%> (ø) ⬆️
.../core-state/src/wallets/wallet-repository-clone.ts 0.00% <0.00%> (ø)
...ate/src/wallets/wallet-repository-copy-on-write.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c558ddd...88a3295. Read the comment docs.

@faustbrian faustbrian merged commit b87899a into 3.0 Feb 14, 2020
23 of 24 checks passed
23 of 24 checks passed
lint (12.x)
Details
test-unit (12.x)
Details
test-integration (12.x)
Details
test-functional-bridgechain-registration (12.x)
Details
test-functional-bridgechain-resignation (12.x)
Details
test-functional-bridgechain-update (12.x)
Details
test-functional-business-registration (12.x)
Details
test-functional-business-resignation (12.x)
Details
test-functional-business-update (12.x)
Details
test-functional-delegate-registration (12.x)
Details
test-functional-delegate-resignation (12.x)
Details
test-functional-htlc-claim (12.x)
Details
test-functional-htlc-lock (12.x)
Details
test-functional-htlc-refund (12.x)
Details
test-functional-ipfs (12.x)
Details
test-functional-multi-payment (12.x)
Details
test-functional-multi-signature-registration (12.x)
Details
test-functional-second-signature-registration (12.x)
Details
test-functional-transfer (12.x)
Details
test-functional-vote (12.x)
Details
benchmark (12.x)
Details
codecov/patch 0.00% of diff hit (target 47.15%)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codecov/project 47.19% (+0.03%) compared to 09ef047
Details
@ArkEcosystemBot ArkEcosystemBot deleted the refactor/core-state/wallet-repositories branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.