Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-magistrate): make bridgechain genesis hash only unique per wallet #3523

Merged
merged 12 commits into from Feb 25, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Feb 21, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2020

This pull request introduces 1 alert when merging 56a6508 into 021ad47 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 24, 2020

This pull request introduces 1 alert when merging e6514fa into 239f12e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #3523 into 2.6 will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6    #3523      +/-   ##
==========================================
+ Coverage   66.10%   66.15%   +0.04%     
==========================================
  Files         440      440              
  Lines       12570    12473      -97     
  Branches     1733     1714      -19     
==========================================
- Hits         8309     8251      -58     
+ Misses       4227     4188      -39     
  Partials       34       34              
Impacted Files Coverage Δ
...-transactions/src/handlers/business-resignation.ts 57.89% <0.00%> (ø) ⬆️
...te-transactions/src/handlers/bridgechain-update.ts 46.15% <0.00%> (+0.91%) ⬆️
...nsactions/src/handlers/bridgechain-registration.ts 71.18% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbb82f3...9a91d2d. Read the comment docs.

@air1one air1one marked this pull request as ready for review February 24, 2020 10:02
@faustbrian faustbrian merged commit 29019ce into 2.6 Feb 25, 2020
@ghost ghost deleted the refactor/magistrate/nethash-unique-wallet branch February 25, 2020 08:22
@ghost ghost removed the Status: Needs Review label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants