Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): jemalloc compatibility for ubuntu 16.04 #3567

Merged
merged 1 commit into from Mar 4, 2020

Conversation

@alessiodf
Copy link
Contributor

alessiodf commented Mar 3, 2020

Summary

@geopsllc reported that Core couldn't find libjemalloc on Ubuntu 16.04.

I reproduced this and it seems whereis in Ubuntu 16.04 doesn't traverse /usr/lib/{architecture}/ to find binaries, whereas 18.04's version does. Since the package manager installs libjemalloc to that directory, Core doesn't find it on 16.04 even when it is properly installed.

Replaced whereis with output from gcc --print-search-dirs which now also works on 16.04 as well as the others (since gcc is always installed as part of the Core installation).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 3, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 4, 2020

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 64084a0 into ArkEcosystem:2.6 Mar 4, 2020
22 checks passed
22 checks passed
crypto (12.x)
Details
bridgechain-registration (12.x)
Details
unit (12.x)
Details
bridgechain-resignation (12.x)
Details
integration (12.x)
Details
bridgechain-update (12.x)
Details
e2e (12.x) e2e (12.x)
Details
business-registration (12.x)
Details
business-resignation (12.x)
Details
business-update (12.x)
Details
delegate-registration (12.x)
Details
delegate-resignation (12.x)
Details
htlc-claim (12.x)
Details
htlc-lock (12.x)
Details
htlc-refund (12.x)
Details
ipfs (12.x)
Details
multi-payment (12.x)
Details
multi-signature-registration (12.x)
Details
second-signature-registration (12.x)
Details
transfer (12.x)
Details
vote (12.x)
Details
LGTM analysis: JavaScript No code changes detected
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Mar 4, 2020

Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.