Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-blockchain): increase coverage to 100% #3604

Merged
merged 11 commits into from Mar 24, 2020

Conversation

@air1one
Copy link
Collaborator

air1one commented Mar 19, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #3604 into develop will increase coverage by 6.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3604      +/-   ##
===========================================
+ Coverage    80.78%   87.55%   +6.76%     
===========================================
  Files          439      439              
  Lines        10121    10121              
  Branches      1301     1301              
===========================================
+ Hits          8176     8861     +685     
+ Misses        1941     1256     -685     
  Partials         4        4              
Impacted Files Coverage Δ
...ssor/handlers/incompatible-transactions-handler.ts 100.00% <ø> (+100.00%) ⬆️
...c/processor/handlers/nonce-out-of-order-handler.ts 100.00% <ø> (+100.00%) ⬆️
packages/core-blockchain/src/blockchain.ts 100.00% <100.00%> (+100.00%) ⬆️
packages/core-blockchain/src/service-provider.ts 100.00% <0.00%> (+100.00%) ⬆️
...kages/core-blockchain/src/state-machine/machine.ts 100.00% <0.00%> (+100.00%) ⬆️
...s/core-blockchain/src/processor/block-processor.ts 100.00% <0.00%> (+100.00%) ⬆️
...core-blockchain/src/state-machine/state-machine.ts 100.00% <0.00%> (+100.00%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937ffa0...3827e49. Read the comment docs.

@air1one air1one changed the title test(core blockchain): 100% unit tests coverage test(core-blockchain): 100% unit tests coverage Mar 19, 2020
@faustbrian faustbrian changed the title test(core-blockchain): 100% unit tests coverage test(core-blockchain): increase coverage to 100% Mar 20, 2020
faustbrian and others added 2 commits Mar 24, 2020
@air1one air1one marked this pull request as ready for review Mar 24, 2020
@air1one air1one requested review from faustbrian and kristjank as code owners Mar 24, 2020
@faustbrian faustbrian merged commit 6c8c436 into develop Mar 24, 2020
24 checks passed
24 checks passed
lint (12.x)
Details
test-unit (12.x)
Details
test-integration (12.x)
Details
test-functional-bridgechain-registration (12.x)
Details
test-functional-bridgechain-resignation (12.x)
Details
test-functional-bridgechain-update (12.x)
Details
test-functional-business-registration (12.x)
Details
test-functional-business-resignation (12.x)
Details
test-functional-business-update (12.x)
Details
test-functional-delegate-registration (12.x)
Details
test-functional-delegate-resignation (12.x)
Details
test-functional-htlc-claim (12.x)
Details
test-functional-htlc-lock (12.x)
Details
test-functional-htlc-refund (12.x)
Details
test-functional-ipfs (12.x)
Details
test-functional-multi-payment (12.x)
Details
test-functional-multi-signature-registration (12.x)
Details
test-functional-second-signature-registration (12.x)
Details
test-functional-transfer (12.x)
Details
test-functional-vote (12.x)
Details
benchmark (12.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codecov/patch 100.00% of diff hit (target 80.78%)
Details
codecov/project 87.55% (+6.76%) compared to 937ffa0
Details
@ArkEcosystemBot ArkEcosystemBot deleted the test/core-blockchain-3.0 branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.