Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-kernel): process env over .env #3935

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR solves #3933

If process.env is defined it will be used even if variable is defined in .env file.

Checklist

  • Ready to be merged

@sebastijankuzner sebastijankuzner force-pushed the chore/core-kernel/process-env-over-.env branch from e97fb1c to 305ba16 Compare August 6, 2020 08:15
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #3935 into develop will decrease coverage by 83.80%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3935       +/-   ##
============================================
- Coverage    97.56%   13.76%   -83.81%     
============================================
  Files          629      629               
  Lines        14540    14541        +1     
  Branches      1729     1730        +1     
============================================
- Hits         14186     2001    -12185     
- Misses         165    12425    +12260     
+ Partials       189      115       -74     
Flag Coverage Δ
#functional 6.82% <0.00%> (-0.01%) ⬇️
#integration 9.85% <0.00%> (-0.01%) ⬇️
#unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/core-kernel/src/services/config/drivers/local.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/cli.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/commands/top.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-cli/src/contracts.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-forger/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/listeners.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/commands/help.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 560 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d8c93...305ba16. Read the comment docs.

@air1one air1one merged commit 640b9a1 into develop Aug 7, 2020
@ghost ghost deleted the chore/core-kernel/process-env-over-.env branch August 7, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants