Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(magistrate-api): extend /node/fees and /transactions/fees with entities static fees #4047

Merged
merged 1 commit into from Sep 18, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Sep 18, 2020

Summary

Resolves #4043 .
Extend /node/fees and /transactions/fees with entities static fees for register / update / resign.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #4047 into develop will decrease coverage by 0.02%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4047      +/-   ##
===========================================
- Coverage    96.48%   96.46%   -0.03%     
===========================================
  Files          715      715              
  Lines        17216    17230      +14     
  Branches      2098     2098              
===========================================
+ Hits         16611    16621      +10     
- Misses         414      418       +4     
  Partials       191      191              
Flag Coverage Δ
#functional 5.97% <0.00%> (-0.01%) ⬇️
#integration 10.17% <73.33%> (+0.04%) ⬆️
#unit 94.45% <73.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/core-magistrate-api/src/service-provider.ts 83.33% <73.33%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab1d91...9a6691a. Read the comment docs.

@faustbrian faustbrian merged commit 773eb8c into develop Sep 18, 2020
@ghost ghost deleted the chore/magistrate-extend-api-fees branch September 18, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants