Fix getPBFTForgingStatus returning NaN #745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both allowedToForge and syncedPeers are 0 the division returns NaN which looks a bit weird in the log. Return 0 instead of NaN.
Before:
[2018-07-10 19:11:28][INFO] : Network PBFT status: NaN
After:
[2018-07-10 19:13:17][INFO] : Network PBFT status: 0