Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clang-tidy #138

Merged
merged 4 commits into from Oct 9, 2019

Conversation

@sleepdefic1t
Copy link
Member

commented Oct 7, 2019

Summary

It appears Clang-Tidy hasn't been working for a while now.

https://github.com/ArkEcosystem/cpp-client/runs/244421081#step:6:1
https://github.com/ArkEcosystem/cpp-client/runs/242002683#step:7:1
https://circleci.com/gh/ArkEcosystem/cpp-client/1551

The current CMake file incorrectly expects Clang-tidy v.6 since #116.
Since Tidy is part of the Clang-5 workflow, this PR changes the CMake config to use v.5

It also removes a non-working -header-filter call.
The current behavior is identical to the default clang-tidy -header-filter default of .*.
Since it doesn't work as expected, there's no reason to have it.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Additional Comments

Clang-Tidy tests may fail/take a long time because it is checking the entire CURL and GTest libraries and their tests.
This also happens without the header-filter option as seen here:

A subsequent PR will address this issue.

faustbrian and others added 2 commits Oct 8, 2019
@sleepdefic1t

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

@faustbrian
That failure is expected.

This PR was just to get Tidy actually running at all.
I plan to address proper filtering in another PR, but can work on it here if you prefer.

@faustbrian faustbrian merged commit 2394fb9 into ArkEcosystem:develop Oct 9, 2019
5 checks passed
5 checks passed
arduino
Details
platformio
Details
linux-gcc7
Details
linux-clang-5
Details
macos
Details
@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:fix/clang-tidy branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.