New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Paths Interface #46

Merged
merged 1 commit into from Jan 1, 2019

Conversation

Projects
None yet
3 participants
@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Jan 1, 2019

Proposed changes

This PR is targeting the develop branch.

Some implementations may rely on a gateway or bridge to communicate with the internet.
This is especially more common in IoT and mesh networks.
This PR adds an interface to support environments where a properly formatted URL can be obtained for passing to another device.

• Add 'Host' class
• Add 'Host' tests
• Update CMakeLists.txt to find 'Host' class & test

• Add Path Interface
• Add Path tests
• Update CMakeLists.txt to find 'Paths' & test
• Add Path examples in documentation

• Update API headers to include 'Host'
• Update API Classes to utilize Paths
• Update MockApi to utilize Paths

• Remove 'host' and 'ip' from 'HTTP'
• Remove 'HTTP' 'setHost' class and mock methods
• Update 'HTTP' to receive only a formatted request/url

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
feature: add Paths Interface
• Add 'Host' class
• Add 'Host' tests
• Update CMakeLists.txt to find 'Host' class & test

• Add Path Interface
• Add Path tests
• Update CMakeLists.txt to find 'Paths' & test
• Add Path examples in documentation

• Update API headers to include 'Host'
• Update API Classes to utilize Paths
• Update MockApi to utilize Paths

• Remove 'host' and 'ip' from 'HTTP'
• Remove 'HTTP' 'setHost' class and mock methods
• Update 'HTTP' to receive only a formatted request/url
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 1, 2019

Codecov Report

Merging #46 into develop will increase coverage by 35.49%.
The diff coverage is 84.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #46       +/-   ##
============================================
+ Coverage    37.93%   73.42%   +35.49%     
============================================
  Files           20       23        +3     
  Lines          203      301       +98     
============================================
+ Hits            77      221      +144     
+ Misses         126       80       -46
Impacted Files Coverage Δ
src/include/cpp-client/connection/connection.h 100% <ø> (ø) ⬆️
src/api/votes/votes.cpp 0% <0%> (ø) ⬆️
src/api/wallets/wallets.cpp 0% <0%> (ø) ⬆️
src/api/delegates/delegates.cpp 0% <0%> (ø) ⬆️
src/api/node/node.cpp 0% <0%> (ø) ⬆️
src/api/transactions/transactions.cpp 0% <0%> (ø) ⬆️
src/api/peers/peers.cpp 0% <0%> (ø) ⬆️
src/include/cpp-client/api/abstract.h 100% <100%> (ø) ⬆️
src/include/cpp-client/api/api.h 100% <100%> (ø) ⬆️
src/include/cpp-client/api/base.h 100% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac698f3...e2fec9c. Read the comment docs.

@faustbrian faustbrian changed the title feature: add Paths Interface feat: add Paths Interface Jan 1, 2019

@faustbrian faustbrian merged commit 2487e93 into ArkEcosystem:develop Jan 1, 2019

5 checks passed

ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details

@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:feat/path-interface branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment