New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clear warnings #47

Merged
merged 5 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@ciband
Copy link
Collaborator

ciband commented Jan 2, 2019

Proposed changes

Removed static from base path functions to clear warnings. If this function is in a header it is public and should not be static.

Types of changes

  • Other... Please describe: Cleared warning

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Further comments

N/A

ciband added some commits Jan 2, 2019

chore: Remove static decoration from base path functions
Removed static from base path functions to clear warnings.  If this function is in a header it is public and should not be static.
@sleepdefic1t

This comment has been minimized.

Copy link
Contributor

sleepdefic1t commented Jan 2, 2019

Platform:
• macOS Mojave 10.14.2

Good catch on the pre-incrementation 👍

Build failure for me on static removal.

[100%] Linking CXX executable Ark-Cpp-Client-tests
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/paths.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/paths.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/paths.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/paths.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/paths.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/paths.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/paths.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/blocks.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/blocks.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/blocks.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/blocks.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/blocks.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/blocks.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/blocks.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/delegates.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/delegates.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/delegates.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/delegates.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/delegates.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/delegates.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/delegates.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/node.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/node.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/node.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/node.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/node.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/node.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/node.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/peers.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/peers.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/peers.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/peers.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/peers.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/peers.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/peers.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/transactions.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/transactions.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/transactions.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/transactions.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/transactions.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/transactions.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/transactions.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/votes.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/votes.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/votes.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/votes.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/votes.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/votes.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/votes.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/wallets.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/wallets.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/wallets.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/wallets.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/wallets.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/wallets.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    CMakeFiles/Ark-Cpp-Client-tests.dir/api/wallets.cpp.o
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(paths.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(paths.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(paths.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(paths.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(paths.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(paths.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(paths.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(blocks.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(blocks.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(blocks.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(blocks.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(blocks.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(blocks.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(blocks.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(delegates.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(delegates.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(delegates.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(delegates.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(delegates.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(delegates.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(delegates.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(node.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(node.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(node.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(node.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(node.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(node.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(node.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(peers.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(peers.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(peers.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(peers.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(peers.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(peers.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(peers.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(transactions.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(transactions.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(transactions.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(transactions.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(transactions.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(transactions.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(transactions.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(votes.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(votes.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(votes.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(votes.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(votes.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(votes.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(votes.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths7Wallets4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(wallets.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Peers4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(wallets.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths12Transactions4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(wallets.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths6Blocks4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(wallets.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths5Votes4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(wallets.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths9Delegates4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(wallets.cpp.o)
duplicate symbol __ZN3Ark6Client3API5Paths4Node4baseEv in:
    CMakeFiles/Ark-Cpp-Client-tests.dir/connection/connection.cpp.o
    ../src/libArk-Cpp-Client-lib.a(wallets.cpp.o)
ld: 112 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [test/Ark-Cpp-Client-tests] Error 1
make[1]: *** [test/CMakeFiles/Ark-Cpp-Client-tests.dir/all] Error 2
make: *** [all] Error 2

I tested making those extern as well:
e.g.

// paths.h
namespace Node
{
  extern const char* base();
  /***/
  extern std::string configuration(Host& newHost);
  /***/
  extern std::string status(Host& newHost);
  /***/
  extern std::string syncing(Host& newHost);
  /***/
};
// paths.cpp
/**
 * Delegate // <- *typo from #46, should be 'Node'
 **/
const char* Ark::Client::API::Paths::Node::base() { return "/api/v2/node"; }

Builds and passes OK with extern.

@ciband

This comment has been minimized.

Copy link
Collaborator

ciband commented Jan 2, 2019

Windows didn't seem to care (and it should have cared, lol).

I'm assuming this function should be public to the user? If so then I'll make the extern changes.

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor

sleepdefic1t commented Jan 2, 2019

😂

Yes, the base endpoint should be public 👍
Thank you, @ciband !

ciband added some commits Jan 2, 2019

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor

sleepdefic1t commented Jan 2, 2019

Looks good!

This can be merged, @faustbrian

@faustbrian faustbrian merged commit 35c93f5 into ArkEcosystem:develop Jan 3, 2019

3 of 5 checks passed

ci/circleci: build-macos-9-2 Please select a macOS plan.
Details
ci/circleci: build-macos-9-3 Please select a macOS plan.
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment