New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidated PIO configuration #48

Merged
merged 4 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@ciband
Copy link
Collaborator

ciband commented Jan 3, 2019

Proposed changes

Combined common PIO config data into a common section

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

@sleepdefic1t
Copy link
Contributor

sleepdefic1t left a comment

Changes look good 👍
Thank you, @ciband

This can be merged.

@ciband

This comment has been minimized.

Copy link
Collaborator

ciband commented Jan 10, 2019

Build failures are due to these tests:

/home/circleci/project/test/api/two/two_transactions.cpp:78: Failure
Expected equality of these values:
45024866
epoch
Which is: 45024880
[ FAILED ] api.test_two_transaction (55 ms)

/home/circleci/project/test/api/two/two_votes.cpp:77: Failure
Expected equality of these values:
45024867
epoch
Which is: 45024890
[ FAILED ] api.test_two_vote (54 ms)

I'm not sure why/how the epoch changed for the transaction that we are inspecting.

This issue will not be an issue once develop gets merged into main.

These build failures are not a result of this change. This change only changed the PIO build and those builds pass.

@faustbrian faustbrian merged commit 49840e8 into ArkEcosystem:master Jan 11, 2019

3 of 5 checks passed

ci/circleci: build-macos-9-2 Please select a macOS plan.
Details
ci/circleci: build-macos-9-3 Please select a macOS plan.
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
@faustbrian

This comment has been minimized.

Copy link
Contributor

faustbrian commented Jan 11, 2019

@ciband anything you want to do before I tag 1.0.0?

@ciband

This comment has been minimized.

Copy link
Collaborator

ciband commented Jan 11, 2019

@faustbrian Just pushed commits to fix up merges for cpp-client and the clang tidy PR.

It appears that host unit test is failing from the develop merge (at least locally for me). We'll see what CI does. Everything looks ok "on paper" but I haven't tried to debug it.

No pending features or anything on my end to stop a 1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment