New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add clang tidy support to CI #49

Merged
merged 2 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@ciband
Copy link
Collaborator

ciband commented Jan 3, 2019

Proposed changes

Added clang tidy support to the clang CI target. As a first step warnings will not fail the build. Once we are down to 0 warnings, we can make warnings fail the build.

Types of changes

  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Further comments

N/A

ciband added some commits Jan 3, 2019

Merge pull request #1 from ArkEcosystem/master
merge master into master
feat: Add clang tidy support to CI
Added clang tidy support to the clang CI target. As a first step warnings will not fail the build. Once we are down to 0 warnings, we can make warnings fail the build.
@ciband

This comment has been minimized.

Copy link
Collaborator

ciband commented Jan 3, 2019

v1 tests are failing again. Not sure why. No test code was changed.

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor

sleepdefic1t commented Jan 3, 2019

Re: V1 tests.
Looks like the peer was syncing.
Not critical since it should be deprecated any time now.

@sleepdefic1t
Copy link
Contributor

sleepdefic1t left a comment

Changes look good.

V1 test failure due to syncing node.
I support just ignoring the failing test.
It's more a testing issue, and 'develop' is already using mocks for V2.

@ciband

This comment has been minimized.

Copy link
Collaborator

ciband commented Jan 4, 2019

Restarted CI to see if the v1 will pass now. clang-tidy runs after the build/test step so I would like it to prove that it works. It passed in my local CI. Same code is running in cpp-crypto.

@sleepdefic1t
Copy link
Contributor

sleepdefic1t left a comment

All tests now passing 👍

@faustbrian faustbrian merged commit bce9cf0 into ArkEcosystem:master Jan 4, 2019

3 of 5 checks passed

ci/circleci: build-macos-9-2 Please select a macOS plan.
Details
ci/circleci: build-macos-9-3 Please select a macOS plan.
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment