Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): Correct Supported Platforms #98

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@sleepdefic1t
Copy link
Contributor

commented Jul 2, 2019

As reported by @yhyuan in ArkEcosystem/cpp-crypto#104,
the current library manifest uses a wildcard * for the platforms value signifying that it supports all platforms.

This is incorrect as the Cpp SDK's only officially support the espressif8266 & espressif32 platforms.

This PR corrects that discrepancy.

What kind of change does this PR introduce?

  • Other, please describe:

Affects external package manager library manifest

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • [n/a] New/updated tests are included
fix(manifests): correct supported platforms
The current library manifest uses a wildcard `*` for the `platforms` value incorrectly signifying that it supports all platforms.

This is incorrect as the Cpp SDK's only officially support the espressif8266 & espressif32 platforms.

This PR corrects this discrepancy.
@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #98 into develop will decrease coverage by 73.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #98       +/-   ##
============================================
- Coverage      100%   26.93%   -73.07%     
============================================
  Files           14       14               
  Lines          245      245               
============================================
- Hits           245       66      -179     
- Misses           0      179      +179
Impacted Files Coverage Δ
src/api/paths.cpp 0% <0%> (-100%) ⬇️
src/http/os/http.cpp 51.11% <0%> (-48.89%) ⬇️
src/include/cpp-client/http/http.h 60% <0%> (-40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d4946...085e3f4. Read the comment docs.

@faustbrian faustbrian merged commit f39aebe into ArkEcosystem:develop Jul 2, 2019

6 checks passed

ci/circleci: build-arduino-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details

@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:fix(manifest)/correct-supported-platforms branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.