refactor(configuration): Support Bridgechains & Custom Configurations #105
The current implementation only allows use with Devnet unless values are manually changed in
These changes enable network configuration via the ARK Crypto library api.
Specifically this PR does the following:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
There are two breaking changes in this PR.
The PR fulfills these requirements:
@@ Coverage Diff @@ ## develop #105 +/- ## =========================================== + Coverage 91.14% 91.52% +0.37% =========================================== Files 27 30 +3 Lines 836 861 +25 =========================================== + Hits 762 788 +26 + Misses 74 73 -1
I will take a look when I am back in a few days but just a quick note on the public API part (disregard if not relevant)
All our crypto packages are being built with the lack of any knowledge about networking as that isn't and shouldn't be of any concern for crypto to work. How the developer decides to feed the configuration to the package is also not the concern of the crypto package, the only concern it has is to receive the configuration in a specific format.
If that configuration came from a remote API, file or function that just generated an object isn't our concern and we shouldn't be involved in that process.