Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Visual Studio Support #122

Merged

Conversation

@ciband
Copy link
Collaborator

commented Aug 2, 2019

Added back missing JSON file that integrates cmake build system into the Visual Studio IDE.

Cleared warnings.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ciband ciband requested review from faustbrian, kristjank and supaiku0 as code owners Aug 2, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ciband ciband changed the base branch from master to develop Aug 2, 2019

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

@ciband
Figured out macOS CI builds aren't triggered if you're tracking from your CircleCI account and do not have a macOS plan.
If you disable C++ Crypto from your CircleCI account,
subsequent PR's will default to the organization and trigger all PR checks 👍

@ciband ciband changed the title Bug/fix visual studio support Fix Visual Studio Support Aug 5, 2019

@ciband

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 5, 2019

@sleepdefic1t I've disabled my circleci for this repo. Are you able to re-trigger CI for this PR? I do not seem to have access.

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

@ciband
Nope. It's still tied to your CircleCi account.
It would have to be closed and resubmitted in a new PR to get picked up by the Organization account...
That's doing too much. lol

Just from looking at it, that's totally legal in macOS and should have no issues.
std::vector<>::size just evaluates to an unsigned integer,
which was probably why Windows wanted you to be explicit with the initial value.

This looks good to go, @faustbrian 👍

@faustbrian faustbrian changed the title Fix Visual Studio Support chore: Visual Studio Support Aug 7, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 03288a3 into ArkEcosystem:develop Aug 7, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build-arduino-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

sleepdefic1t added a commit to sleepdefic1t/cpp-crypto that referenced this pull request Aug 7, 2019

sleepdefic1t added a commit to sleepdefic1t/cpp-crypto that referenced this pull request Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.