Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add debug support for VS Code #125

Merged
merged 5 commits into from Aug 13, 2019

Conversation

@ciband
Copy link
Collaborator

commented Aug 7, 2019

Added support for VS Code line by line debugging
Added support for building from VS Code IDE
Added support for GTest extension within VS Code

This ultimately adds easy line by line debugging support for Windows, Mac, and Linux.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

ciband added some commits Aug 7, 2019

feat: Add support for VS Code debugging
Added support for VS Code line by line debugging
Added support for building from VS Code IDE
Added support for GTest extension within VS Code

@ciband ciband requested review from faustbrian, kristjank and supaiku0 as code owners Aug 7, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ciband ciband changed the base branch from master to develop Aug 7, 2019

ciband added some commits Aug 7, 2019

chore: Removing trailing comma
Removed trailing comma to adhere to code standards.

@ciband ciband changed the title Add debug support for VS Code feat: Add debug support for VS Code Aug 12, 2019

@sleepdefic1t sleepdefic1t self-requested a review Aug 13, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit ddae781 into ArkEcosystem:develop Aug 13, 2019

7 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: build-arduino-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.