Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
chore: Add support for Visual Studio 2019 #135
Updated CMakeSettings.json to support Visual Studio 2019 compilers and schema.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
If adding a new feature, the PR's description includes:
@@ Coverage Diff @@ ## develop #135 +/- ## ======================================== Coverage 91.82% 91.82% ======================================== Files 33 33 Lines 856 856 ======================================== Hits 786 786 Misses 70 70
As is this moves us forward to 2019 (upgrade). If we want to support development on older compilers then we can do that. We could also just support the older stuff in CI and keep the configuration small for just develop in 2019.…
Sent from my iPhone
On Aug 26, 2019, at 18:36, Simon ***@***.***> wrote: @ciband Just to double check because I'm not familiar this, will this still support 2017, or does this basically change the requirement to 2019? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Just to be clear, are you wanting to support developers developing cpp-crypto in VS2017 and VS2019?
Support only VS2019 (latest/greatest) for developers and then support VS2017 and VS2019 in CI.
The pattern being develop in the latest IDE but we support the latest 2 version of the compiler.
We don't do this for Linux, we kind of do this for Mac with xcode.
@sleepdefic1t I think we need to be consistent. If we want developers to be able to use the 2017 compiler or the 2019 compiler, then I think CI should reflect that (meaning once we actually get Windows CI up and running via Appveyor or CircleCI).
For this PR and its scope, I'm hearing to support both so I will Add the VS2017 configs back in.
Okay, sounds good.
I know nothing about Windows Dev, I just know a lot of the students we saw at Hackathons didn’t usually have the latest releases. Lots of 2015 configs in repos too, so I don’t want to force people into 2019 if we can just offer it as an option.
I appreciate your guidance on the Windows stuff.
Appveyor failure due to plan time execution limits. Debug passed, release was aborted.
This works on VS2019 with the VS2017 changes. It tries to invoke the VS2017 compiler under VS2019 for the appropriate config.
I still need to test on a pure VS2017 machine to see how it handles the VS2019 configs but I don't foresee any issues.
My laptop HD is small so I had to uninstall VS2017.