Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove `header-filter` clang-tidy call #154

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@sleepdefic1t
Copy link
Member

commented Oct 7, 2019

Summary

The regex call in header-filter doesn't work as expected.
The current behavior is identical to the default clang-tidy -header-filter default of .*.

You can see the regex not being obeyed in any of the passing "actions" or back on CircleCI.

https://github.com/ArkEcosystem/cpp-crypto/runs/244420978#step:6:1
https://github.com/ArkEcosystem/cpp-crypto/runs/242577996#step:6:1
https://circleci.com/gh/ArkEcosystem/cpp-crypto/1595

Since it doesn't work and is misleading, this PR removes that call.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Additional Comments.

CI will fail on PlatformIO builds due to not using explicit package versions.
A subsequent PR will address this issue.

@faustbrian faustbrian merged commit b7ae092 into ArkEcosystem:develop Oct 8, 2019
7 checks passed
7 checks passed
arduino-default
Details
linux-default
Details
linux-gcc7
Details
linux-clang-5
Details
macOS
Details
windows (Debug)
Details
windows (Release)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.