Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move packages out of source #156

Merged
merged 7 commits into from Oct 8, 2019

Conversation

@sleepdefic1t
Copy link
Member

commented Oct 7, 2019

Summary

External libraries are currently submoduled in the source tree which leads to more complex builds and makes maintaining and debugging more difficult.

This PR moves external libraries to extern in the root dir and drops submodules in favor CMake methods of fetching dependencies.

Specifically, this PR does the following:

  • removes all git submodules.
  • adds CMake configs to get extern libs.
  • updates CMake configurations and naming.
  • makes building tests optional.
  • updates build scripts.
  • updates Actions/CI scripts and workflow.
  • updates PIO configuration files.
  • updates the Arduino IDE helper script.
  • updates the changelog.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Additional Comments

PIO build failure is resolved in #155

sleepdefic1t and others added 3 commits Oct 7, 2019
@faustbrian

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@sleepdefic1t platformio failing

sleepdefic1t added 2 commits Oct 8, 2019
@faustbrian faustbrian merged commit 6ec802b into ArkEcosystem:develop Oct 8, 2019
7 checks passed
7 checks passed
arduino
Details
platformio
Details
linux-gcc7
Details
linux-clang-5
Details
macOS
Details
windows (Debug)
Details
windows (Release)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.