New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix ESP8266 Unit Tests #169
test: fix ESP8266 Unit Tests #169
Conversation
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
CI failures for coverage and Windows look to be CI issues and out of scope for this PR. The Windows failure looks like a bug in the script to call the unit test exe. Should this be written up as an Issue and worked separately? |
Windows Issues addressed in #170 This is a good PR, but a fairly sizable one. Quick thought, What are your feelings on splitting off the ESP8266/PIO part to a separate PR? Nice work as always regardless, @ciband |
I agree that this will be helpful on other small RAM platforms. I certain can split it up but I’m not exactly sure where to draw the line. I’d prefer to keep it as is as I think the changes are all dependent on each other. That being said if you can give me some more details on what you want to split I can work that. |
True, they’re kinda tied together.. But only in that the split up tests enables 8266 to run them successfully. Splitting them up would, hypothetically, allow tests to pass on other devices too. So how about this PR just splits the tests with the purpose of enabling smaller platforms to pass unit tests. Those could be in a separate PR that enables 8266 now that the unit tests can support smaller architectures. |
* Leveraged broken up unit tests to restore support for running unit tests on ESP8266. * Changed testing program to loop execute the unit tests for easier debugging
Added extern directory to .gitignore to prevent working tree polution
9a50a81
to
40c329c
Compare
Split out files as requested. They are in #172 and they must be merged before this PR. |
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
Summary
This PR fixes the broken unit tests for esp8266. The theme of this PR is breaking up the unit tests to allow the tests to run on the esp8266 hardware without running out of RAM and blowing the stack.
The current status of the PR has all tests passing except to_array and to_json. These tests simply do not fit into RAM as currently implemented. I think this should be a different issue and PR.
Checklist
Fixes #169
Depends on #172