Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always include amount in transaction payloads #202

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@sleepdefic1t
Copy link
Member

sleepdefic1t commented Feb 10, 2020

Summary

Core 2.6 requires the "amount" json key be present in all transaction payloads.

The current C++ Crypto implementation does not include this key in transaction types that do not have an "amount".

These changes ensure the "amount" key is added to all transaction payloads.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
 Core 2.6 requires the "amount" json key be present in all transaction payloads.

The current C++ Crypto implementation does not include this key in transaction types that do not have an "amount".

These changes ensure the "amount" key is added to all transaction payloads.
@faustbrian faustbrian changed the title fix: transaction payload amount key fix: always include amount in transaction payloads Feb 10, 2020
@faustbrian faustbrian merged commit b96d24c into ArkEcosystem:develop Feb 10, 2020
8 checks passed
8 checks passed
codecov
Details
arduino
Details
platformio
Details
linux-gcc7
Details
linux-clang-5
Details
macOS
Details
windows (Debug)
Details
windows (Release)
Details
@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:fix/payload-amount branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.