Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.0.0 #203

Merged
merged 22 commits into from Feb 14, 2020
Merged

release: 1.0.0 #203

merged 22 commits into from Feb 14, 2020

Conversation

@sleepdefic1t
Copy link
Member

sleepdefic1t commented Feb 13, 2020

Summary

This release primarily adds AIP-11 Support (#90).

This release also includes a massive rewrite of the transactions classes to improve readability and maintainability, as well as resolves several bugs in the process.

Additionally, the following specific changes may be found in the CHANGELOG, as well as the following PRs:

  • break up unit tests to support platforms with limited RAM #172
  • removed use of monolithic arkCrypto.h header #190
  • added AIP-11 support for Core v.2.6 Transactions #198
  • fixed transaction::to_array tests on ESP8266 #178
  • fixed transaction::to_json tests on ESP8266 #180

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
sleepdefic1t and others added 21 commits Oct 18, 2019
CodeClimate Coverage apparently attempts to use the `CC_TEST_REPORTER_ID` of the PR base for reporting to the upstream parent, which fails.

This PR splits workflows so that CodeClimate Coverage onlys runs on Pushes to master/devleop.

CodeCov will continue to run on PR's and Pushes.
Broke up unit tests into smaller parts to better support
devices with limited RAM.  This allows for the creation of
smaller unit test firmware images.
Broke up the transaction::to_array tests to reduce stack usage and
allow for support on esp8266.
* fix: fix transaction::to_json tests on esp8266

Broke up the transaction::to_json tests to reduce stack usage and
allow for support on esp8266.
* Disabled WiFi  radio during tests to lower current  draw.
* Increased CPU frequency to execute tests faster to improve
   stability.  Stability has been improved but is not perfect.  There is
   ~15% failure rate when running complex tests where the board
   goes through a DMT reset.
* refactor: remove usage of monolithic arkCrypto.h

* Updated arkCrypto.h header to just be a dummy header for the sole
   purpose of forcing the cpp-crypto library to be linked into an
   Arduino sketch.
* Updated tests to use specific headers instead of arkCrypto.h
* Updated Arduino sample sketches to use only the headers required
   for the sketch.

* chore: update comments

- add note on ESP8266 Arduino CPU speed.
- reword comment in `arkCrypto.h` to be less than 80 characters.
Moved global const data to function local to reduce
global memory footprint on embedded platforms.
- ignores detached head warnings when cloning external libs from CMake.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #203 into master will increase coverage by 8.35%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #203      +/-   ##
========================================
+ Coverage   91.64%   100%   +8.35%     
========================================
  Files          33     61      +28     
  Lines         862   1187     +325     
========================================
+ Hits          790   1187     +397     
+ Misses         72      0      -72
Impacted Files Coverage Δ
src/include/cpp-crypto/networks/testnet.hpp 100% <ø> (ø) ⬆️
src/include/cpp-crypto/networks/devnet.hpp 100% <ø> (ø) ⬆️
src/include/cpp-crypto/networks/mainnet.hpp 100% <ø> (ø) ⬆️
src/include/cpp-crypto/common/network.hpp 100% <ø> (ø) ⬆️
src/include/cpp-crypto/crypto/message.hpp 100% <ø> (ø) ⬆️
src/transactions/types/multi_payment.hpp 100% <100%> (ø)
src/include/cpp-crypto/interfaces/identities.hpp 100% <100%> (ø)
...cpp-crypto/transactions/builders/multi_payment.hpp 100% <100%> (ø)
src/identities/keys.cpp 100% <100%> (ø) ⬆️
src/utils/base58.cpp 100% <100%> (ø) ⬆️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcd0ae...95b72bd. Read the comment docs.

@faustbrian faustbrian changed the title release: v.1.0.0 release: 1.0.0 Feb 14, 2020
@faustbrian faustbrian merged commit f06376c into master Feb 14, 2020
10 checks passed
10 checks passed
codecov
Details
arduino
Details
platformio
Details
linux-gcc7
Details
linux-clang-5
Details
macOS
Details
windows (Debug)
Details
windows (Release)
Details
codecov/patch 100% of diff hit (target 91.64%)
Details
codecov/project 100% (+8.35%) compared to 8fcd0ae
Details
@ArkEcosystemBot ArkEcosystemBot deleted the release/v1.0.0 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.