New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update codecov to ignore extras directory #32

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@ciband
Contributor

ciband commented Nov 30, 2018

Proposed changes

Extras directory should be ignore in code coverage calculations. This was missed in the #31.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe: Code coverage accuracy

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

@ciband

This comment has been minimized.

Contributor

ciband commented Nov 30, 2018

macOS build issues due to #27

@sleepdefic1t

Looks good 👍

This can be merged.

@faustbrian faustbrian merged commit d4324c3 into ArkEcosystem:master Dec 3, 2018

3 checks passed

ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment