New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add clang tidy support to CI #39

Merged
merged 3 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@ciband
Copy link
Collaborator

ciband commented Jan 3, 2019

Proposed changes

Added clang tidy support to the clang CI target. As a first step warnings will not fail the build. Once we are down to 0 warnings, we can make warnings fail the build.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Further comments

N/A

ciband added some commits Jan 3, 2019

feat: Add clang tidy support to CI
feat:  Add clang tidy support to CI

Added clang tidy support to the clang CI target.  As a first step warnings will not fail the build.  Once we are down to 0 warnings, we can make warnings fail the build.
@sleepdefic1t
Copy link
Contributor

sleepdefic1t left a comment

Changes look good.

This can be merged 👍

@faustbrian faustbrian merged commit 88e058e into ArkEcosystem:master Jan 4, 2019

3 of 5 checks passed

ci/circleci: build-macos-9-2 Please select a macOS plan.
Details
ci/circleci: build-macos-9-3 Please select a macOS plan.
Details
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details

ciband added a commit to ciband/cpp-crypto that referenced this pull request Jan 4, 2019

merge master into scratch/fix_clang_tidy
* chore: Clean up PlatformIO configs (ArkEcosystem#37)

* chore:  Clean up PIO files

Cleaned up PIO files to make use of common sections and reduce duplication

* chore:  Delete generated files

* docs: fix documentation sdk url (ArkEcosystem#38)

* chore: Add Arduino IDE Script (ArkEcosystem#41)

* feat: Add Arduino Script

Cpp-Crypto uses an 'include' folder scheme to expose the public interface.
The Arduino IDE does not support this.

This script extends support to the Arduino IDE by moving headers from 'include' into their reletive directories in the 'src' folder.

Additionally, once this script has been ran, it can be executed again to undo these changes.

* fix: typo

"reletive" >> "relative"

* chore: Correct typo (ArkEcosystem#40)

* chore: Add clang tidy support to CI (ArkEcosystem#39)

Added clang tidy support to the clang CI target.  As a first step warnings will not fail the build.  Once we are down to 0 warnings, we can make warnings fail the build.

ciband added a commit to ciband/cpp-crypto that referenced this pull request Jan 4, 2019

merge master into scratch/fix_clang_tidy
* chore: Clean up PlatformIO configs (ArkEcosystem#37)

* chore:  Clean up PIO files

Cleaned up PIO files to make use of common sections and reduce duplication

* chore:  Delete generated files

* docs: fix documentation sdk url (ArkEcosystem#38)

* chore: Add Arduino IDE Script (ArkEcosystem#41)

* feat: Add Arduino Script

Cpp-Crypto uses an 'include' folder scheme to expose the public interface.
The Arduino IDE does not support this.

This script extends support to the Arduino IDE by moving headers from 'include' into their reletive directories in the 'src' folder.

Additionally, once this script has been ran, it can be executed again to undo these changes.

* fix: typo

"reletive" >> "relative"

* chore: Correct typo (ArkEcosystem#40)

* chore: Add clang tidy support to CI (ArkEcosystem#39)

Added clang tidy support to the clang CI target.  As a first step warnings will not fail the build.  Once we are down to 0 warnings, we can make warnings fail the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment