New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clang Tidy Fixes #42

merged 33 commits into from Jan 10, 2019


None yet
3 participants
Copy link

ciband commented Jan 4, 2019

Proposed changes

Various fixes for clang tidy

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Further comments


ciband added some commits Jan 3, 2019

merge master into scratch/fix_clang_tidy
* chore: Clean up PlatformIO configs (#37)

* chore:  Clean up PIO files

Cleaned up PIO files to make use of common sections and reduce duplication

* chore:  Delete generated files

* docs: fix documentation sdk url (#38)

* chore: Add Arduino IDE Script (#41)

* feat: Add Arduino Script

Cpp-Crypto uses an 'include' folder scheme to expose the public interface.
The Arduino IDE does not support this.

This script extends support to the Arduino IDE by moving headers from 'include' into their reletive directories in the 'src' folder.

Additionally, once this script has been ran, it can be executed again to undo these changes.

* fix: typo

"reletive" >> "relative"

* chore: Correct typo (#40)

* chore: Add clang tidy support to CI (#39)

Added clang tidy support to the clang CI target.  As a first step warnings will not fail the build.  Once we are down to 0 warnings, we can make warnings fail the build.
misc: Disable cpp core guidelines checks
Disable cpp core guidelines checks until we bring in GSL support.

ciband added some commits Jan 4, 2019

fix: Revert disabling failing CI on clang tidy error
The previous commit was unintentional.
Copy link

sleepdefic1t left a comment

Very nice!

Not sure where this stands with the new bounty program,
but I’m good with this being merged 👍

@faustbrian faustbrian merged commit 223b5d1 into ArkEcosystem:master Jan 10, 2019

3 of 5 checks passed

ci/circleci: build-macos-9-2 Please select a macOS plan.
ci/circleci: build-macos-9-3 Please select a macOS plan.
ci/circleci: build-linux-clang-5 Your tests passed on CircleCI!
ci/circleci: build-linux-default Your tests passed on CircleCI!
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment