New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Update Library Config #55

Merged
merged 12 commits into from Feb 6, 2019

Conversation

Projects
None yet
3 participants
@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Feb 5, 2019

Proposed changes

This PR does the following in the Library Configuration file:

  • lists ArduinoJson as a dependency,
  • adds the Arduino sketch path to config.
  • fixes the platformio_example path.

This allows external package managers to properly list our examples and handle project dependencies.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

adds to and updates library configuration file.

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

sleepdefic1t added some commits Dec 5, 2018

Merge pull request #1 from ArkEcosystem/master
misc: merge from upstream
misc: update library config
- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
misc: update library config
- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 5, 2019

@sleepdefic1t Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 5, 2019

@faustbrian @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 5, 2019

@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 7d63198373aa41546e1a7718ce2385bb3afb2cc6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

1 similar comment
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 5, 2019

@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 7d63198373aa41546e1a7718ce2385bb3afb2cc6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor Author

sleepdefic1t commented Feb 5, 2019

Test failure in build-linux-clang-5 is a result of #7

@sleepdefic1t sleepdefic1t referenced this pull request Feb 5, 2019

Merged

chore: Bump Version #56

3 of 12 tasks complete
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 6, 2019

@sleepdefic1t A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 16e51a1 into ArkEcosystem:master Feb 6, 2019

4 of 5 checks passed

ci/circleci: build-linux-clang-5 Your tests failed on CircleCI
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details

@ArkEcosystem ArkEcosystem deleted a comment from ArkEcosystemBot Feb 6, 2019

@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:misc/update-library-config branch Feb 15, 2019

ciband added a commit to ciband/cpp-crypto that referenced this pull request Feb 18, 2019

chore: Update Library Config (ArkEcosystem#55)
* misc: update library config

- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.

* Revert "misc: update library config"

This reverts commit 55d830b.

* misc: update library config

- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment