Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: library config examples' paths #57
Conversation
sleepdefic1t
added some commits
Dec 5, 2018
This comment has been minimized.
This comment has been minimized.
@sleepdefic1t Thanks for submitting this pull request, a maintainer will get back to you shortly! |
This comment has been minimized.
This comment has been minimized.
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ArkEcosystemBot
requested review from
air1one
and
faustbrian
Feb 8, 2019
faustbrian
approved these changes
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
@sleepdefic1t A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
ArkEcosystemBot
added
the
Status: Contributor Approved
label
Feb 8, 2019
faustbrian
merged commit fe90270
into
ArkEcosystem:master
Feb 8, 2019
3 of 5 checks passed
This comment has been minimized.
This comment has been minimized.
@sleepdefic1t Your pull request has been merged but was not assigned a bounty tier. @air1one @faustbrian - please assign a bounty tier to this pull request in the next few days. |
sleepdefic1t commentedFeb 8, 2019
Proposed changes
PlatformIO uses globbing in
library.json
for the 'examples' paths.This PR drops explicit path naming in favor of the wildcard(*) syntax.
This allows SDK examples to be properly displayed in the PIO library manager.
Types of changes
Checklist