New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Unneeded/Redundant Manifest Fields #58

Merged
merged 14 commits into from Feb 10, 2019

Conversation

Projects
None yet
3 participants
@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Feb 9, 2019

Proposed changes

This PR removes the following fields from library.json:

  • "export"
  • "examples"

Releases should include all files and folders from the root/ dir for the source code zip.
Also, Per PIO, the "examples" field not being present defaults to the paths that are already shown. So this part is just redundant.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

sleepdefic1t added some commits Dec 5, 2018

Merge pull request #1 from ArkEcosystem/master
misc: merge from upstream
misc: update library config
- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
fix: Remove Unneeded Manifest Fields
- Releases should include all files from the 'root/' dir for the source code zip.

- per PIO, the "examples field" not being present defaults to the paths that are already shown. So this part is just redundant.
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 9, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

ArkEcosystemBot commented Feb 9, 2019

@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 4fbf5681d102112f389373ffa1c55e8a675714c7. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t

This comment has been minimized.

Copy link
Contributor Author

sleepdefic1t commented Feb 9, 2019

Failing test is known in #7, the changes in this PR do not affect this failure.

@ArkEcosystem ArkEcosystem deleted a comment from ArkEcosystemBot Feb 10, 2019

@faustbrian faustbrian merged commit fe7e5ff into ArkEcosystem:master Feb 10, 2019

4 of 5 checks passed

ci/circleci: build-linux-clang-5 Your tests failed on CircleCI
Details
ci/circleci: build-linux-default Your tests passed on CircleCI!
Details
ci/circleci: build-linux-gcc7 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-2 Your tests passed on CircleCI!
Details
ci/circleci: build-macos-9-3 Your tests passed on CircleCI!
Details

@sleepdefic1t sleepdefic1t deleted the sleepdefic1t:fix/rm-manifest-fields branch Feb 15, 2019

ciband added a commit to ciband/cpp-crypto that referenced this pull request Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment