Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bulk generation command #15

Merged
merged 14 commits into from Nov 8, 2019

Conversation

@faustbrian
Copy link
Contributor

faustbrian commented Nov 7, 2019

Summary

Adds the bulk command to generate fixtures of all types with all signatures.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged
faustbrian added 4 commits Nov 7, 2019
@faustbrian faustbrian marked this pull request as ready for review Nov 7, 2019
faustbrian added 7 commits Nov 7, 2019

builder.sign(passphrases[0]);

// todo

This comment was marked as resolved.

Copy link
@supaiku0

supaiku0 Nov 7, 2019

Only type 4 needs to be signed, normal multisignature transactions only have signatures which means the verify() below will fail since that doesn't take them into account.

}

const transaction: Interfaces.ITransaction = builder.build();

if (!transaction.verify()) {

This comment was marked as resolved.

Copy link
@supaiku0

supaiku0 Nov 7, 2019

We could do:
https://github.com/ArkEcosystem/core/blob/develop/packages/core-state/src/wallets/wallet.ts#L136 if it's a multisignature transaction including verify() if it's type 4.

faustbrian and others added 2 commits Nov 7, 2019
@faustbrian faustbrian merged commit 355c123 into master Nov 8, 2019
2 checks passed
2 checks passed
lint (12.x)
Details
build (12.x)
Details
@ArkEcosystemBot ArkEcosystemBot deleted the bulk branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.