Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use CORE_PATH_CONFIG and --network flag #51

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@faustbrian
Copy link
Contributor

faustbrian commented Apr 15, 2019

  • Do not use the CORE_PATH_CONFIG environment variable but instead let core discover the configuration from ~/.config/{token}-core/<network>/*.
  • Do not use --network but instead let core discover the network from ~/.config/{token}-core/<network>/*.
@alexbarnsley

This comment has been minimized.

Copy link
Member

alexbarnsley commented Apr 15, 2019

image

image

It needs to know what network to specify. Removing the use of --network means it doesn't know.

@faustbrian

This comment has been minimized.

Copy link
Contributor Author

faustbrian commented Apr 15, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

alexbarnsley commented Apr 15, 2019

That means they can only ever start 1 network using deployer, whatever network is chosen during install. If that's how you want it to work, then there needs to be something in this PR to allow people to change networks. That was the whole point of the --network flag for the start-core command (which is required by the way):

./bridgechain.sh start-core --network mainnet
@faustbrian

This comment has been minimized.

Copy link
Contributor Author

faustbrian commented Apr 15, 2019

I think the whole config part should be changed. Right now everything is hardcoded and bound to the repository paths rather than relying on the auto detection of core like it is used in a real production environment.

Will close this and think about how to sort this out as it feels odd to use right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.