Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add vendorfield length to readme & configs #62

merged 1 commit into from May 27, 2019


Copy link

commented May 27, 2019

What kind of change does this PR introduce? (check at least one)

  • Documentation
  • Other, please describe: config defaults

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@alexbarnsley alexbarnsley merged commit 21a818e into develop May 27, 2019

@ArkEcosystemBot ArkEcosystemBot deleted the chore/add-vendorfield-readme branch May 27, 2019

ItsANameToo added a commit that referenced this pull request May 27, 2019
merge develop to master (#63)
* feat: implement cli, alias & env caching (#52)

* refactor: let core auto-detect configuration

* refactor: copy configuration on start if the bridgechain directory exists

* refactor: better configuration publishment check

* feat: check core config on start

* fix: var curly braces in strings

* fix: move core config on start to after dir check

* fix: navigate to core path for config setup

* fix: check if .config directories don't exist

* fix: args json return when already processed

* feat: store env data

* fix: use .config path

* feat: create alias for bridgechain

* fix: don't abort when stopping and no network

* fix: path export in profile for vagrant

* chore: remove comment

* refactor: make core alias global

* feat: update core package & cli output

* fix: pass network into stop commands

* feat: improvements to deployer setup (#53)

* feat: peer install option

* fix: drop current user if exists

* fix: drop owned objects by current user if exists

* fix: drop all core databases if exists

* fix: allow for no owned databases

* fix: don't sudo yarn

* fix: git properties in sample config

* refactor: check for empty core origin

* fix: if pull fails, try master

* fix: skip drop local user on failure

* fix: ignore network reach on first start

* fix: prefix if number

* chore: set explorer ip default to all ips

* chore: editorconfig for js deployer script

* fix: milestones generation for rewards per block

* fix: dynamic fees toggle

* fix: license & git checks for null/empty

* fix: list user's databases

* feat: modify core install script

* feat: use chain name as alias for core

* fix: alias setup to correct path

* fix: avoid global variable name clash

* feat: force public core ip for explorer if 127

* refactor: only load env if no json

* chore: deploy core 2.3.22

* fix: remove core published config

* fix: prevent non-alphanum chars in chain name

* refactor: improve for peer script

* fix: multiline bug

* feat: allow setting vendorfield length

* fix: process

* fix: remove exec at end of

* refactor: blocktime all lowercase

* fix: add vendorFieldLength to joi schema

* fix: vendorFieldLength case in json

* fix: use correct name for network

* fix: re-add chain name for deployer config

* fix: hardcoded paths for

* refactor: remove peer install option

* chore: add vendorfield length to readme & configs (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.