Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt the contacts page to new design #1007

Merged
merged 12 commits into from Jan 28, 2019

Conversation

Projects
None yet
6 participants
@j-a-m-l
Copy link
Contributor

commented Jan 21, 2019

Proposed changes

This PR updates the design of the contacts page.
Solves #992 (some of the requested points were rejected).

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Jan 24, 2019

Codecov Report

Merging #1007 into develop will increase coverage by 0.11%.
The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
+ Coverage    38.38%   38.49%   +0.11%     
===========================================
  Files          201      201              
  Lines         5030     5026       -4     
  Branches       986      989       +3     
===========================================
+ Hits          1931     1935       +4     
+ Misses        2976     2969       -7     
+ Partials       123      122       -1
Impacted Files Coverage Δ
src/renderer/components/Wallet/WalletTable.vue 12% <ø> (+1.65%) ⬆️
src/renderer/pages/Contact/ContactAll.vue 17.07% <58.33%> (ø) ⬆️
src/renderer/store/modules/peer.js 70.75% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a452c...f3b5709. Read the comment docs.

@alexbarnsley
Copy link
Member

left a comment

Looks good overall. I Wasn't sure what the identicon meant with the "i" though. This was on a profile with an avatar 🤔

I've put in for 1 change about the padding, but you can confirm with Oleg first

</span>
</button>
<div class="ContactAll flex flex-col">
<div class="ContactAll__header flex flex-row space-between bg-theme-feature rounded-lg px-10 py-2 mb-3">

This comment has been minimized.

Copy link
@alexbarnsley

alexbarnsley Jan 24, 2019

Member

Can we change this to py-5 instead of py-2, I think the identicon looks a little close to the edge:

py-2:
image

py-5:
image

This comment has been minimized.

Copy link
@j-a-m-l

j-a-m-l Jan 24, 2019

Author Contributor

I've changed it. I was feeling the same way, but I tried to follow the original design.

This comment has been minimized.

Copy link
@j-a-m-l

j-a-m-l Jan 24, 2019

Author Contributor

@olejegcord could you confirm this change?

This comment has been minimized.

Copy link
@olejegcord

olejegcord Jan 24, 2019

Please make "I" more bold 2-3 times.
"py-5" - ok =)

@dated

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

It might be worthwhile to think about a design where the top bar is not always present. The page in itself is pretty self explanatory and I find the bar a bit superfluous just for the create button.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

@dated it might be a little superfluous now, but we could add, in the near future, more buttons, such as a way to filter contacts, etc.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

Increased the font weight of the "i" and conflicts resolved

@luciorubeens luciorubeens merged commit 4aff82b into develop Jan 28, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the new-contacts-style branch Jan 28, 2019

luciorubeens added a commit that referenced this pull request Jan 29, 2019

chore: release 2.2.1 (#1041)
* improvement: make wallet heading name more visible in dark mode (#996)

* fix: correctly handle zero balance on wallet heading info (#1000)

* fix: conditional alignment of items (#1005)

* improvement: adjust announcement section to fit new design (#982)

* improvement: new instructions section for wallet import/new and network overview page (#1003)

* improvement: new instructions section for wallet import page
* improvement: new instructions section for wallet new page
* improvement: new instructions section for network overview page

* refactor: new wallet selection styles and ui (#1006)

* fix: do not shake when generating new wallets (#1008)

* refactor: success/error colors and delay on clipboard button tooltip (#1010)

* refactor: success/error colors and delay on clipboard button tooltip

* misc: use tailwind classes


Co-authored-by: Lúcio Rubens <luciorubeens@gmail.com>

* docs: fix and improve the instructions of how to translate the app (#1004)

* feat: adapt the contact creation page to new style (#1012)

* refactor: how to infer which background to use on contact new page

* test: adapt the tests

* misc: include the new background for the contact creation page

* feat: add new design to the contact creation page

* refactor: rename contact creation background from `purse.svg` to `wallet.svg`

* refactor: remove unnecessary delegate api calls (#995)

* refactor: differentiate between wallet and contact rename (#988)

* feat/fix: validation on sign/verify modals & signed messages alignment (#1014)

* feat: validation on sign/verify modals

* misc: add :focus color to input icons

* fix: signed message alignment

* refactor: remove nested if branch

* fix: json validation

* misc: update example json format

* feat: different network name style & add ledger flags (#991)

* feat: different style for names provided by the network

* fix: show only ledger wallet if address is also watch only wallet

* fix: correct sorting by name if numerical

* refactor: ledger badge in wallet sidebar

* fix: show wallet/contact name

* feat: make whole wallet/contact card clickable

* feat: network name tooltip on wallet/contact grid view

* fix: create contact card alignment

* misc: set hover styles to wallet/contact name on card

* fix: network name tooltip condition

* misc: remove wallet/contact name hover classes

* misc: stop click propagation on card name and balance

* misc: ledger badge styles and tooltip

* fix: sidebar truncation length if ledger

* docs: remove the beta warning and collpase list of commands (#1020)

* feat: allow expanding and collapsing the wallet/contact sidebar (#1015)

* fix: inconsistencies between network versions (#1016)

* fix: transaction fees for v1 networks

* chore: update @arkecosystem/client

* fix: store isHttps for current peer in client

* fix: broadcast tx if no other peers

* refactor: rename method to get peer api version

* fix: check config for core-api excluding prefix(es)

* fix: getters return empty array if no peers

* fix: check peer if v2 to update props, not network

* refactor: get /config from wallet to remove header

* fix: only swap ports on refresh if not already

* test: fix by passing peers in as v2 peers not v1

* fix: set tx timestamp based on network epoch

* fix: sending to single peer if broadcast off

* fix: use 3s timeout when broadcasting to peers

* fix: add forged to delegate model (#1017)

* fix: add forged to delegate model

* test: adjust delegate fixtures and tests

* feat: persistent sorting in wallet/contact table (#1002)

* feat: persistent sorting in wallet/contact table

* test: add getter & setter tests

* refactor: replace the profile avatars with a new component `ProfileAvatar` (#1019)

* refactor: extract the `ProfileAvatar` component from the main sidemenu

* refactor: `ProfileAll` to include `ProfileAvatar`

* fix: avoid breaking the layout and displacing links when the profile balance has 8 decimals

* refactor: extract the `ProfileAvatar` component from the main sidemenu

* refactor: `ProfileAll` to include `ProfileAvatar`

* fix: avoid breaking the layout and displacing links when the profile balance has 8 decimals

* refactor: use the `ProfileAvatar` on the wallets page

* refactor: use the `ProfileAvatar` on the remove profile confirmation

* fix: adjust the position of the avatar on wallet page

* fix: importing of profile avatar selection modal component (#1031)

* feat: adapt the contacts page to new design (#1007)

* feat: show contact balance on list layout

* feat: adapt the contacts page to the new style

* refactor: increase padding

* fix: increase the font weight of the "i" badge on contact placeholder

* feat: show contact balance on list layout

* feat: adapt the contacts page to the new style

* refactor: increase padding

* fix: increase the font weight of the "i" badge on contact placeholder


Co-authored-by: Alex Barnsley <8069294+alexbarnsley@users.noreply.github.com>
Co-authored-by: Lúcio Rubens <luciorubeens@gmail.com>

* refactor: invert identicon hover behaviour (#1025)

* feat: add sidebar animation (#1021)

* feat: add sidebar animation

* misc: speed up transition

* fix: errors during and after removing profiles (#1033)

* fix: do not fail on the profile creation page when removing the last profile

* fix: do not fail at start due not having an active profile

* test: the profile removal confirmation

* fix: avoid errors when removing a profile

* feat: loading screen when broadcasting to many peers (#1023)

* fix: don't modify modal loader state

* chore: correct ModalLoder name

* feat: ModalLoader emit closed

* feat: show loader on broadcast to many peers

* fix: timeout when getting peer config

* feat: allow close warning message override

* refactor: update close message for slow broadcasting


Co-authored-by: Juan <j-a-m-l@users.noreply.github.com>

* fix: allow selecting the balance on the wallet page heading (#994)

* fix: show "Unvote" action on delegate tab when using Ledger (#1032)

* fix: do not fail when voting with Ledger

* fix: show the "Unvote" button at the bottom of the delegate tab when using Ledger wallets

* refactor: new selection design for the network overview (#1037)

* change instructions image

* refactor: new selection design for the network overview

* fix: broadcasting modal not closing on unvote (#1038)

* chore: update @arkecosystem/client (#1036)

* feat: use network static fees as max (#1022)

* chore: update @arkecosystem/client to 0.1.19

* feat: client method to fetch static fees

* feat: tx store method to update static fees

* feat: update static fees on peer change

* feat: inputFee component use static if available

* test: fix failing

* test: api client service fetchStaticFees

* test: transaction store with static fees

* docs: jsdoc for new methods

* refactor: store fees against network, not profile

* test: refactor to use network not profile

* fix: update fees when changing peer or custom

* chore: update wallet import and networks pages headings (#1039)

* fix: numbers with colon (",") and other formats on the send transfer inputs (#1009)

* chore: bump to 2.2.1 (#1040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.