Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace the profile avatars with a new component `ProfileAvatar` #1019

Merged
merged 12 commits into from Jan 28, 2019

Conversation

Projects
None yet
4 participants
@j-a-m-l
Copy link
Contributor

commented Jan 24, 2019

Proposed changes

The profile avatars were used on several places, so I've created a new component for that:

  • component AppSidemenu
  • component ProfileRemovalConfirmation
  • page ProfileAll
  • page WalletAll

Apart from that, this PR fixes a problem that was occurring when the balance has 8 decimals:
[Before]
screenshot_20190124_203719

[After]
screenshot_20190124_203323

To do it, I've reduced slightly the card padding and the padding between the avatar image/letter and the links.

Other problem was that the ProfileRemovalConfirmation wasn't displaying letter avatars.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@codecov-io

This comment has been minimized.

Copy link

commented Jan 24, 2019

Codecov Report

Merging #1019 into develop will increase coverage by <.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1019      +/-   ##
===========================================
+ Coverage    38.38%   38.38%   +<.01%     
===========================================
  Files          200      201       +1     
  Lines         5028     5030       +2     
  Branches       986      990       +4     
===========================================
+ Hits          1930     1931       +1     
- Misses        2975     2976       +1     
  Partials       123      123
Impacted Files Coverage Δ
.../components/Profile/ProfileRemovalConfirmation.vue 33.33% <ø> (+13.33%) ⬆️
...enderer/components/App/AppSidemenu/AppSidemenu.vue 0% <ø> (ø) ⬆️
src/renderer/components/Button/ButtonLetter.vue 66.66% <ø> (-33.34%) ⬇️
src/renderer/components/Profile/ProfileAvatar.vue 100% <100%> (ø)
src/renderer/pages/Wallet/WalletAll.vue 47.69% <80%> (+0.81%) ⬆️
src/renderer/pages/Profile/ProfileAll.vue 66.66% <88.88%> (-0.91%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21347fb...de842b3. Read the comment docs.

@j-a-m-l j-a-m-l changed the title [WIP] refactor: replace the profile avatars with a new component `ProfileAvatar` refactor: replace the profile avatars with a new component `ProfileAvatar` Jan 25, 2019

@alexbarnsley

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

All looks good and seems to be working. I think it removed most my Avatars, but that could be down to my dev setup. It didn't again when i added some back 🤷‍♂️

The only issue i can see is that the gap between avatar and text has increased in the Wallet header so now it looks closer to the left than the text:

image

Maybe it's just my eyes 🤔 it did move back though when i went to the develop branch

@j-a-m-l

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

@alexbarnsley adjusted

@luciorubeens luciorubeens merged commit 045f5ad into develop Jan 28, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the profile-avatar-component branch Jan 28, 2019

luciorubeens added a commit that referenced this pull request Jan 29, 2019

chore: release 2.2.1 (#1041)
* improvement: make wallet heading name more visible in dark mode (#996)

* fix: correctly handle zero balance on wallet heading info (#1000)

* fix: conditional alignment of items (#1005)

* improvement: adjust announcement section to fit new design (#982)

* improvement: new instructions section for wallet import/new and network overview page (#1003)

* improvement: new instructions section for wallet import page
* improvement: new instructions section for wallet new page
* improvement: new instructions section for network overview page

* refactor: new wallet selection styles and ui (#1006)

* fix: do not shake when generating new wallets (#1008)

* refactor: success/error colors and delay on clipboard button tooltip (#1010)

* refactor: success/error colors and delay on clipboard button tooltip

* misc: use tailwind classes


Co-authored-by: Lúcio Rubens <luciorubeens@gmail.com>

* docs: fix and improve the instructions of how to translate the app (#1004)

* feat: adapt the contact creation page to new style (#1012)

* refactor: how to infer which background to use on contact new page

* test: adapt the tests

* misc: include the new background for the contact creation page

* feat: add new design to the contact creation page

* refactor: rename contact creation background from `purse.svg` to `wallet.svg`

* refactor: remove unnecessary delegate api calls (#995)

* refactor: differentiate between wallet and contact rename (#988)

* feat/fix: validation on sign/verify modals & signed messages alignment (#1014)

* feat: validation on sign/verify modals

* misc: add :focus color to input icons

* fix: signed message alignment

* refactor: remove nested if branch

* fix: json validation

* misc: update example json format

* feat: different network name style & add ledger flags (#991)

* feat: different style for names provided by the network

* fix: show only ledger wallet if address is also watch only wallet

* fix: correct sorting by name if numerical

* refactor: ledger badge in wallet sidebar

* fix: show wallet/contact name

* feat: make whole wallet/contact card clickable

* feat: network name tooltip on wallet/contact grid view

* fix: create contact card alignment

* misc: set hover styles to wallet/contact name on card

* fix: network name tooltip condition

* misc: remove wallet/contact name hover classes

* misc: stop click propagation on card name and balance

* misc: ledger badge styles and tooltip

* fix: sidebar truncation length if ledger

* docs: remove the beta warning and collpase list of commands (#1020)

* feat: allow expanding and collapsing the wallet/contact sidebar (#1015)

* fix: inconsistencies between network versions (#1016)

* fix: transaction fees for v1 networks

* chore: update @arkecosystem/client

* fix: store isHttps for current peer in client

* fix: broadcast tx if no other peers

* refactor: rename method to get peer api version

* fix: check config for core-api excluding prefix(es)

* fix: getters return empty array if no peers

* fix: check peer if v2 to update props, not network

* refactor: get /config from wallet to remove header

* fix: only swap ports on refresh if not already

* test: fix by passing peers in as v2 peers not v1

* fix: set tx timestamp based on network epoch

* fix: sending to single peer if broadcast off

* fix: use 3s timeout when broadcasting to peers

* fix: add forged to delegate model (#1017)

* fix: add forged to delegate model

* test: adjust delegate fixtures and tests

* feat: persistent sorting in wallet/contact table (#1002)

* feat: persistent sorting in wallet/contact table

* test: add getter & setter tests

* refactor: replace the profile avatars with a new component `ProfileAvatar` (#1019)

* refactor: extract the `ProfileAvatar` component from the main sidemenu

* refactor: `ProfileAll` to include `ProfileAvatar`

* fix: avoid breaking the layout and displacing links when the profile balance has 8 decimals

* refactor: extract the `ProfileAvatar` component from the main sidemenu

* refactor: `ProfileAll` to include `ProfileAvatar`

* fix: avoid breaking the layout and displacing links when the profile balance has 8 decimals

* refactor: use the `ProfileAvatar` on the wallets page

* refactor: use the `ProfileAvatar` on the remove profile confirmation

* fix: adjust the position of the avatar on wallet page

* fix: importing of profile avatar selection modal component (#1031)

* feat: adapt the contacts page to new design (#1007)

* feat: show contact balance on list layout

* feat: adapt the contacts page to the new style

* refactor: increase padding

* fix: increase the font weight of the "i" badge on contact placeholder

* feat: show contact balance on list layout

* feat: adapt the contacts page to the new style

* refactor: increase padding

* fix: increase the font weight of the "i" badge on contact placeholder


Co-authored-by: Alex Barnsley <8069294+alexbarnsley@users.noreply.github.com>
Co-authored-by: Lúcio Rubens <luciorubeens@gmail.com>

* refactor: invert identicon hover behaviour (#1025)

* feat: add sidebar animation (#1021)

* feat: add sidebar animation

* misc: speed up transition

* fix: errors during and after removing profiles (#1033)

* fix: do not fail on the profile creation page when removing the last profile

* fix: do not fail at start due not having an active profile

* test: the profile removal confirmation

* fix: avoid errors when removing a profile

* feat: loading screen when broadcasting to many peers (#1023)

* fix: don't modify modal loader state

* chore: correct ModalLoder name

* feat: ModalLoader emit closed

* feat: show loader on broadcast to many peers

* fix: timeout when getting peer config

* feat: allow close warning message override

* refactor: update close message for slow broadcasting


Co-authored-by: Juan <j-a-m-l@users.noreply.github.com>

* fix: allow selecting the balance on the wallet page heading (#994)

* fix: show "Unvote" action on delegate tab when using Ledger (#1032)

* fix: do not fail when voting with Ledger

* fix: show the "Unvote" button at the bottom of the delegate tab when using Ledger wallets

* refactor: new selection design for the network overview (#1037)

* change instructions image

* refactor: new selection design for the network overview

* fix: broadcasting modal not closing on unvote (#1038)

* chore: update @arkecosystem/client (#1036)

* feat: use network static fees as max (#1022)

* chore: update @arkecosystem/client to 0.1.19

* feat: client method to fetch static fees

* feat: tx store method to update static fees

* feat: update static fees on peer change

* feat: inputFee component use static if available

* test: fix failing

* test: api client service fetchStaticFees

* test: transaction store with static fees

* docs: jsdoc for new methods

* refactor: store fees against network, not profile

* test: refactor to use network not profile

* fix: update fees when changing peer or custom

* chore: update wallet import and networks pages headings (#1039)

* fix: numbers with colon (",") and other formats on the send transfer inputs (#1009)

* chore: bump to 2.2.1 (#1040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.