Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: loading screen when broadcasting to many peers #1023
referenced this pull request
Jan 27, 2019
Well the reason I wanted it is because during testing I hit some bad peers on devnet which meant the entire broadcast took a good few minutes to finish, which may have the same result on a bad internet connection. Not showing anything may give the impression it somehow failed to broadcast the transaction at all. The modal itself can be closed after 15 seconds when a close button opens, which I think should be plenty of time to get broadcast unless there are issues.
This is for the less tech-savvy who may not necessarily trust software. To prevent the whole "It doesn't look like it's doing anything. Has it broadcast or...?", only for the "Successfully broadcast" to be sent a few minute later. It's also to prevent sending a new transaction in case they thought the previous one failed.
@@ Coverage Diff @@ ## develop #1023 +/- ## =========================================== - Coverage 38.55% 38.52% -0.04% =========================================== Files 201 201 Lines 5039 5043 +4 Branches 990 987 -3 =========================================== Hits 1943 1943 - Misses 2973 2977 +4 Partials 123 123