Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: overall latest transactions per profile #1034

Merged
merged 4 commits into from Jan 30, 2019

Conversation

@dated
Copy link
Contributor

commented Jan 28, 2019

Proposed changes

Currently the latest transactions display the ten latest transaction of each wallet. This has several problems and downsides, for instance:

a) with a high number of wallets, this list grows very large
b) this doesn't actually reflect the latest transactions of your profile (i am not interested in having transactions in that list of a wallet i last used a year ago)

This PR changes that behaviour and displays the 50 latest transactions of all wallets combined on the dashboard.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated and others added some commits Jan 30, 2019

@j-a-m-l
Copy link
Contributor

left a comment

Changing isReceiver to isRecipient is a good idea 👍

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

Is it okay like this @j-a-m-l?

@j-a-m-l j-a-m-l merged commit 90a6251 into ArkEcosystem:develop Jan 30, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@dated dated deleted the dated:latest-transactions branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.