Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify, when sending transactions, that the 2nd passphrase is correct #1043

Merged
merged 4 commits into from Feb 25, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Jan 30, 2019

Proposed changes

Solves #1042

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@j-a-m-l j-a-m-l changed the title Verify 2nd passphrase feat: verify, when sending transactions, that the 2nd passphrase is correct Jan 30, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 30, 2019

Codecov Report

Merging #1043 into develop will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1043      +/-   ##
===========================================
- Coverage    39.71%   39.52%   -0.19%     
===========================================
  Files          204      204              
  Lines         5132     5138       +6     
  Branches      1012     1014       +2     
===========================================
- Hits          2038     2031       -7     
- Misses        2975     2986      +11     
- Partials       119      121       +2
Impacted Files Coverage Δ
...ransaction/TransactionForm/TransactionFormVote.vue 7.76% <ø> (ø) ⬆️
...action/TransactionForm/TransactionFormTransfer.vue 5.42% <ø> (ø) ⬆️
...renderer/components/Passphrase/PassphraseInput.vue 43.39% <0%> (-5.54%) ⬇️
...actionForm/TransactionFormDelegateRegistration.vue 8.64% <0%> (ø) ⬆️
src/renderer/store/modules/peer.js 70.56% <0%> (-1.87%) ⬇️
src/renderer/services/client.js 66.22% <0%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3b46c...e2c8094. Read the comment docs.

@luciorubeens luciorubeens merged commit ccbee2b into develop Feb 25, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the verify-2nd-passphrase branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.