Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not treat addresses that are on NEO as invalid #1048

Merged
merged 4 commits into from Feb 6, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 1, 2019

Proposed changes

Instead of marking the address as incorrect because there is NEO wallet with the same address, show a message.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Further comments

To test this, https://neotracker.io/

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 1, 2019

Codecov Report

Merging #1048 into develop will decrease coverage by 0.01%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1048      +/-   ##
===========================================
- Coverage    39.48%   39.46%   -0.02%     
===========================================
  Files          205      205              
  Lines         5139     5144       +5     
  Branches      1007     1014       +7     
===========================================
+ Hits          2029     2030       +1     
- Misses        2988     2992       +4     
  Partials       122      122
Impacted Files Coverage Δ
src/renderer/components/Input/InputAddress.vue 41.5% <25%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a4c39...90c8d6a. Read the comment docs.

@luciorubeens luciorubeens merged commit 8b07422 into develop Feb 6, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@luciorubeens luciorubeens deleted the neo-notice-not-error branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.