Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make contacts container scrollable #1052

Merged
merged 2 commits into from Feb 4, 2019

Conversation

@dated
Copy link
Contributor

commented Feb 1, 2019

Proposed changes

Fixes #1051 and cleans up the css a bit.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated added some commits Feb 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@j-a-m-l @alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l

j-a-m-l approved these changes Feb 4, 2019

Copy link
Contributor

left a comment

Thanks @dated

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@dated A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit 2e3b46c into ArkEcosystem:develop Feb 4, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@dated Your pull request has been merged but was not assigned a bounty tier. @j-a-m-l @alexbarnsley @luciorubeens - please assign a bounty tier to this pull request in the next few days.

@dated dated deleted the dated:contacts-scroll branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.