Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/feat: copy button in wallet table, redirect & success message #1053

Merged
merged 8 commits into from Feb 6, 2019

Conversation

@dated
Copy link
Contributor

commented Feb 1, 2019

Proposed changes

Adds the changes described in #1047, i.e:

  • redirect to contacts overview instead of wallet after creating a contact
  • copy address button in action column

and

  • displays a success message once a contact has been created successfully
  • adds tooltips to the buttons

image
image

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

dated added some commits Feb 1, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@j-a-m-l @alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

j-a-m-l added some commits Feb 4, 2019

@j-a-m-l
Copy link
Contributor

left a comment

Everything fine, but 1 small request: change Ledger wallets delete button to use different colour, so it's clear that they can't be deleted (to touch screen users).

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

@dated Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

dated added some commits Feb 6, 2019

@j-a-m-l

j-a-m-l approved these changes Feb 6, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

@dated A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit e14626e into ArkEcosystem:develop Feb 6, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

@dated Your pull request has been merged and marked as tier 3. It will earn you $25 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.