Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: component `InputLanguage` and add language flags to profile #1054

merged 17 commits into from Feb 4, 2019


Copy link

commented Feb 1, 2019

Proposed changes

This PR:

  • Includes a new component InputLanguage
  • Improves and fixes several things of dropdowns and InputSelect
  • Includes the InputLanguge component in the profile creation
  • Modifies the profile edition to display flags on the language dropdown
  • Includes the attribution to the creators of the flag icons (on the about section)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Test (adding missing tests or fixing existing tests)


  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

This comment has been minimized.

Copy link

commented Feb 1, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.


This comment has been minimized.

Copy link

commented Feb 1, 2019

Codecov Report

Merging #1054 into develop will decrease coverage by 0.22%.
The diff coverage is 6.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1054      +/-   ##
- Coverage    39.71%   39.48%   -0.23%     
  Files          204      205       +1     
  Lines         5132     5139       +7     
  Branches      1012     1007       -5     
- Hits          2038     2029       -9     
- Misses        2975     2988      +13     
- Partials       119      122       +3
Impacted Files Coverage Δ
.../components/Menu/MenuDropdown/MenuDropdownItem.vue 100% <ø> (ø) ⬆️
...mponents/Menu/MenuDropdown/MenuDropdownHandler.vue 100% <ø> (ø) ⬆️
...erer/components/Menu/MenuDropdown/MenuDropdown.vue 87.5% <ø> (ø) ⬆️
src/renderer/pages/Profile/ProfileNew.vue 7.93% <0%> (+0.36%) ⬆️
src/renderer/components/Input/InputSelect.vue 56.52% <0%> (+8.37%) ⬆️
src/renderer/pages/Profile/ProfileEdition.vue 8.79% <0%> (-0.1%) ⬇️
src/renderer/components/Input/InputLanguage.vue 15.38% <15.38%> (ø)
src/renderer/store/modules/peer.js 68.69% <0%> (-3.74%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3b46c...b634156. Read the comment docs.

@j-a-m-l j-a-m-l changed the title [WIP] feat: component `InputLanguage` and add language flags to profile feat: component `InputLanguage` and add language flags to profile Feb 1, 2019

Copy link

left a comment

Looks good. Just need to semibold the item to keep the style. And also in the ProfileEdition, since the component was not reused.

class="InputLanguage__item__flag mr-2"
{{ itemScope.item }}

This comment has been minimized.

Copy link

luciorubeens Feb 4, 2019

Suggested change
{{ itemScope.item }}
<span class="font-semibold">
{{ itemScope.item }}

This comment has been minimized.

Copy link

commented Feb 4, 2019

@j-a-m-l Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

Changes implemented


This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

Thanks @luciorubeens. I've made those changes.

@luciorubeens luciorubeens merged commit 75d6b9c into develop Feb 4, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!

@ArkEcosystemBot ArkEcosystemBot deleted the input-language branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.