Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep the expand button at the top #1061

Merged
merged 2 commits into from Feb 6, 2019

Conversation

@j-a-m-l
Copy link
Contributor

commented Feb 5, 2019

Proposed changes

Keeping the button to expand/collapse at the top would allow seeing (expanding) the balance of the last wallets without having to go to the top to expand the sidebar.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

@alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 6, 2019

Codecov Report

Merging #1061 into develop will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1061      +/-   ##
===========================================
- Coverage    39.67%   39.46%   -0.22%     
===========================================
  Files          205      205              
  Lines         5144     5144              
  Branches      1014     1014              
===========================================
- Hits          2041     2030      -11     
- Misses        2984     2992       +8     
- Partials       119      122       +3
Impacted Files Coverage Δ
src/renderer/pages/Wallet/WalletShow.vue 10% <ø> (ø) ⬆️
.../components/Wallet/WalletSidebar/WalletSidebar.vue 13.04% <ø> (ø) ⬆️
src/renderer/store/modules/peer.js 68.69% <0%> (-3.74%) ⬇️
src/renderer/services/client.js 66.22% <0%> (-1.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b07422...add1c46. Read the comment docs.

@luciorubeens luciorubeens merged commit 5b7e9bf into develop Feb 6, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@ArkEcosystemBot ArkEcosystemBot deleted the fixed-sidebar-expand-button branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.