Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs filepath #1062

Merged
merged 1 commit into from Feb 7, 2019

Conversation

@vulet
Copy link
Contributor

commented Feb 7, 2019

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@vulet Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@j-a-m-l @alexbarnsley @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io

This comment has been minimized.

Copy link

commented Feb 7, 2019

Codecov Report

Merging #1062 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1062      +/-   ##
===========================================
+ Coverage    39.52%   39.66%   +0.13%     
===========================================
  Files          205      205              
  Lines         5148     5148              
  Branches      1010     1010              
===========================================
+ Hits          2035     2042       +7     
+ Misses        2992     2987       -5     
+ Partials       121      119       -2
Impacted Files Coverage Δ
...ponents/Wallet/WalletDelegates/WalletDelegates.vue 48.93% <ø> (ø) ⬆️
src/renderer/services/client.js 67.22% <0%> (+1%) ⬆️
src/renderer/store/modules/peer.js 72.42% <0%> (+1.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14626e...6bab18c. Read the comment docs.

@j-a-m-l

j-a-m-l approved these changes Feb 7, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@vulet A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit 638a2d6 into ArkEcosystem:develop Feb 7, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@vulet Your pull request has been merged and marked as tier 6. It will earn you $1 USD.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Thank, @vulet.

@vulet

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@vulet

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

hello @faustbrian, you can just remove the bounty all together. it's not why I submit doc fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.