Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard transaction loading and sidebar placeholder #1065

Merged
merged 3 commits into from Feb 8, 2019

Conversation

@dated
Copy link
Contributor

commented Feb 7, 2019

Proposed changes

Two little fixes:

  1. the loading animation of the dashboard transactions currently shows indefinitely when there are no wallets
  2. when there are no wallets the wallet placeholder in the sidebar shows while loading the ledger

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@alexbarnsley @j-a-m-l @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

@dated when this PR is tested, mention me

@dated dated force-pushed the dated:dashboard-ui branch from 3fab018 to 91e90c7 Feb 7, 2019

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

All good now @j-a-m-l

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@dated The ci/circleci: test-node-9 job is failing as of 3fab0186160e5fa0fa7d12a3d927f0c07eea02f9. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@j-a-m-l
Copy link
Contributor

left a comment

The dashboard fix is OK, but the sidebar change has a side-effect:

{ BEFORE }
screenshot_20190208_200440

{ AFTER }
screenshot_20190208_200529

Both are far from perfect, but first is better.

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@dated Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@dated

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

I undid the css cleanup commit and removed only the unnecessary nested checks for isExpanded @j-a-m-l.

@dated dated force-pushed the dated:dashboard-ui branch from 91e90c7 to 71e6b2c Feb 8, 2019

@j-a-m-l

j-a-m-l approved these changes Feb 8, 2019

@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@dated A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@j-a-m-l j-a-m-l merged commit a7fddee into ArkEcosystem:develop Feb 8, 2019

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details
@ArkEcosystemBot

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@dated Your pull request has been merged and marked as tier 4. It will earn you $10 USD.

@j-a-m-l

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

Thanks @dated

@dated dated deleted the dated:dashboard-ui branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.